Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import ClusterShapeHitFilterESProducer_cfi explicitly in SiPixelPhase1OfflineDQM_source_cff #30141

Merged

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Jun 8, 2020

PR description:

The workflow 138.1 fails in IBs because the ClusterShapeHitFilterESProducer_cfi is not imported/loaded by ALCA step anymore. This PR proposes to import the ClusterShapeHitFilterESProducer explicitly in SiPixelPhase1OfflineDQM_source_cff to guarantee that the ESProducer is available.

Resolves #30140.

PR validation:

Workflow 138.1 runs.

Assumption it would be loaded by something else does not always hold
(e.g. in Cosmic workflow without ALCA).
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30141/15926

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

DQM/SiPixelPhase1Config

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno, @jandrea this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Jun 8, 2020

@cmsbuild, please test workflow 138.1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

+1
Tested at: 253d4fd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-176e21/6869/summary.html
CMSSW: CMSSW_11_2_X_2020-06-07-0000
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-176e21/6869/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-176e21/138.1_RunCosmics2020+RunCosmics2020+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780497
  • DQMHistoTests: Total failures: 48
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780399
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@silviodonato
Copy link
Contributor

merge
thanks @makortel !
cc: @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU

@cmsbuild cmsbuild merged commit f64440e into cms-sw:master Jun 8, 2020
@makortel makortel deleted the fixSiPixelPhase1TrackClustersAnalyzer branch June 8, 2020 13:10
@jfernan2
Copy link
Contributor

+1
For the records

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow 138.1 fails because of missing ClusterShapeHitFilter
4 participants