Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop type specs in RecoLocalCalo and RecoLocalTracker #30147

Merged
merged 5 commits into from Jun 15, 2020

Conversation

jeongeun
Copy link
Contributor

@jeongeun jeongeun commented Jun 8, 2020

PR description: Update the safer syntax for existing parameter

(The reference was PR#29979)
Instead of modifying parameters with full type specs, which can be interpreted as an insertion of a new parameter, it is a safer way to protect from parameter name mistakes and will also help in possible parameter migrations.

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_11_2_X, the basic test all passed in the CMSSW PR instructions.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30147/15931

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

RecoLocalCalo/HGCalRecProducers
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers
RecoLocalTracker/Phase2TrackerRecHits
RecoLocalTracker/SiStripClusterizer
RecoLocalTracker/SiStripRecHitConverter

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@echabert, @felicepantaleo, @yduhm, @robervalwalsh, @argiro, @pfs, @threus, @ebrondol, @sethzenz, @makortel, @lgray, @apsallid, @vandreev11, @pieterdavid, @GiacomoSguazzoni, @rovere, @VinInn, @cseez, @deguio, @hatakeyamak, @alesaggio, @mmusich, @abdoulline, @clelange, @rchatter, @riga, @gbenelli, @edjtscott, @lecriste, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Jun 8, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6889/console Started: 2020/06/08 19:38

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

-1

Tested at: f3dd2a1

CMSSW: CMSSW_11_2_X_2020-06-08-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1136c/6889/summary.html

I found follow errors while testing this PR

Failed tests: Build Python3

  • Build:

I found compilation warning when building: See details on the summary page.

  • Python3:

I found errors:

*** Error compiling 'src/RecoLocalTracker/SiStripRecHitConverter/python/StripCPEgeometric_cfi.py'...

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

UncertaintyScaling = cms.double(1.42),
MinimumUncertainty = cms.double(0.01)
StripCPEgeometricESProducer = stripCPEESProducer.clone(
ComponentName = 'StripCPEgeometric'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commas are missing here...

@cmsbuild
Copy link
Contributor

+1
Tested at: ce8aebf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1136c/6986/summary.html
CMSSW: CMSSW_11_2_X_2020-06-11-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1136c/6986/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2779433
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2779382
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@perrotta
Copy link
Contributor

+1

  • Type specs dropped from python configs, and cloned modules and parameter modifications moved inside the clone method calls to the argument list
  • Jenkins tests pass and show no differences

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants