Improvements to SiStrip Payload Inspector

[mmusich]

PR description:

This PR has three main topics:

• introduce a comparison plot for Strip LA values between two tags or between two IOVs of the same tag:

• extend the SiStripNoisePerDetId and SiStripPedestalPerDetId in order to be able to plot more than one DetId at a time.

• percolate the usage of the new class templates defined at Improvements for Payload inspector #29622

PR validation:

Relies on the existing (and augmented) unit tests.
All the plots have also been checked by hand.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30180/15999

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondCore/SiStripPlugins/plugins/SiStripLorentzAngle_PayloadInspector.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934
  • File CondCore/SiStripPlugins/plugins/SiStripNoises_PayloadInspector.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
  • File CondCore/SiStripPlugins/plugins/SiStripPedestals_PayloadInspector.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks modernize-use-auto #29936

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/SiStripPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @VinInn this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6939/console Started: 2020/06/10 20:17

[cmsbuild]

+1
Tested at: 55370e0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb0b22/6939/summary.html
CMSSW: CMSSW_11_2_X_2020-06-09-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb0b22/6939/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780497
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780446
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1