HYDJET, PYQUEN and the new embedding #30185

wouf · 2020-06-10T21:44:51Z

PR description:

The integrated Pull Request for the:

Full embedding mode for HI generators to use within mixing (as result of discussion in Access edm::event from GeneratorInterface #28636)
New Hydjet version 1.9.1 interface made as external generator (with the Hydjet integration as external cmsdist#5412) and adjusted to use in the updated embedding mode. To replace Hydjet Interface External #28764
PYQUEN update up to version 1.5.4 (Hydjet integration as external cmsdist#5412) with adjustment to use in the updated embedding mode.

More details at https://indico.cern.ch/event/932445/contributions/3935235/attachments/2073197/3480861/HJ1.pdf

PR validation:

The new full embedded mixing may be tested with HYDJET 1.9.1:

a) Creating the underlying HYDJET sample (background):
cmsDriver.py Hydjet_Quenched_MinBias_5020GeV_cfi --conditions auto:phase1_2018_realistic_hi --scenario HeavyIons -n 2 --era Run2_2018_pp_on_AA --eventcontent RAWSIM --relval 9000,100 -s GEN,SIM --datatier GEN-SIM --beamspot Realistic25ns13TeVEarly2018Collision --geometry DB:Extended

b) Creating the embedded HYDJET sample (signal, GEN-SIM):
cmsDriver.py Hydjet_Quenched_B12_5020GeV_cfi --conditions auto:phase1_2018_realistic_hi --scenario HeavyIons -n 2 --era Run2_2018_pp_on_AA --eventcontent RAWSIM --relval 2000,1 -s GEN,SIM --datatier GEN-SIM --beamspot Realistic25ns13TeVEarly2018Collision --geometry DB:Extended --pileup HiMixEmbGEN --pileup_input file:Hydjet_Quenched_MinBias_5020GeV_cfi_GEN_SIM.root --fileout step1_GEN_SIM_PU.root

c) Creating the embedded HYDJET sample (signal, step2):
cmsDriver.py step2 -s DIGI:pdigi_hi,L1,DIGI2RAW,HLT:@Fake2 --conditions auto:phase1_2018_realistic_hi --scenario HeavyIons -n 2 --era Run2_2018_pp_on_AA --eventcontent FEVTDEBUGHLT --datatier GEN-SIM-DIGI-RAW-HLTDEBUG --filein=file:step1_GEN_SIM_PU.root --beamspot Realistic25ns13TeVEarly2018Collision --pileup HiMix --pileup_input file:Hydjet_Quenched_MinBias_5020GeV_cfi_GEN_SIM.root

d) Creating the embedded HYDJET sample (signal, step3):
cmsDriver.py step3 --conditions auto:phase1_2018_realistic_hi --pileup_input file:Hydjet_Quenched_MinBias_5020GeV_cfi_GEN_SIM.root -n 2 --era Run2_2018_pp_on_AA --eventcontent RECOSIM,MINIAODSIM,DQM,ALCARECO --filein=file:step2_DIGI_L1_DIGI2RAW_HLT_PU.root --runUnscheduled -s RAW2DIGI,L1Reco,RECO,ALCA:SiStripCalZeroBias+SiPixelCalZeroBias,EI,PAT,VALIDATION:@standardValidationNoHLT+@miniAODValidation,DQM:@standardDQMFakeHLT+@miniAODDQM --datatier GEN-SIM-RECO,MINIAODSIM,DQMIO,ALCARECO --pileup HiMix

HYDJET validation:
please test workflow 150 with Hydjet integration as external cmsdist#5412
PYQUEN validation:
please test workflow 301.0 with Hydjet integration as external cmsdist#5412

cmsbuild · 2020-06-10T21:45:16Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-10T21:49:23Z

-code-checks

ERROR: Build errors found during clang-tidy run.

GeneratorInterface/HydjetInterface/src/HydjetHadronizer.cc:328:23: error: expected ';' after expression [clang-diagnostic-error]
  LogDebug("SubEvent") std::cout << " Number of sub events " << nsub_;
                      ^
                      ;
GeneratorInterface/HydjetInterface/src/HydjetHadronizer.cc:329:21: error: expected ';' after expression [clang-diagnostic-error]
  LogDebug("Hydjet") std::cout<< " Number of hard events " << hyjpar.njet;
                    ^
                    ;
GeneratorInterface/HydjetInterface/src/HydjetHadronizer.cc:330:21: error: expected ';' after expression [clang-diagnostic-error]
  LogDebug("Hydjet") std::cout<< " Number of hard particles " << nhard_;
                    ^
                    ;
GeneratorInterface/HydjetInterface/src/HydjetHadronizer.cc:361:7: error: use of undeclared identifier 'stab'; did you mean 'swab'? [clang-diagnostic-error]
      stab++;
      ^~~~
      swab
--
GeneratorInterface/HydjetInterface/src/HydjetHadronizer.cc:361:11: error: cannot increment value of type 'void (const void *__restrict, void *__restrict, ssize_t) throw()' (aka 'void (const void *__restrict, void *__restrict, long) throw()') [clang-diagnostic-error]
      stab++;
          ^
GeneratorInterface/HydjetInterface/src/HydjetHadronizer.cc:402:42: error: use of undeclared identifier 'stab'; did you mean 'swab'? [clang-diagnostic-error]
            << ", stable particles: " << stab << std::endl;
                                         ^~~~
                                         swab
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2020-06-10T22:07:49Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-10T22:11:36Z

-code-checks

ERROR: Build errors found during clang-tidy run.

GeneratorInterface/HydjetInterface/src/HydjetHadronizer.cc:361:7: error: use of undeclared identifier 'stab'; did you mean 'swab'? [clang-diagnostic-error]
      stab++;
      ^~~~
      swab
--
GeneratorInterface/HydjetInterface/src/HydjetHadronizer.cc:361:11: error: cannot increment value of type 'void (const void *__restrict, void *__restrict, ssize_t) throw()' (aka 'void (const void *__restrict, void *__restrict, long) throw()') [clang-diagnostic-error]
      stab++;
          ^
GeneratorInterface/HydjetInterface/src/HydjetHadronizer.cc:402:42: error: use of undeclared identifier 'stab'; did you mean 'swab'? [clang-diagnostic-error]
            << ", stable particles: " << stab << std::endl;
                                         ^~~~
                                         swab
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

silviodonato · 2020-07-21T14:11:21Z

+operations

cmsbuild · 2020-07-21T14:11:46Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-07-21T17:00:04Z

please test with cms-sw/cmsdist#5412

cmsbuild · 2020-07-21T17:00:27Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5412

CMSSW_11_2_X_2020-07-21-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8188/console Started: 2020/07/21 19:01

cmsbuild · 2020-07-21T19:13:21Z

+1
Tested at: c459f83
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d1961/8188/summary.html
CMSSW: CMSSW_11_2_X_2020-07-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-21T19:13:27Z

Comparison job queued.

cmsbuild · 2020-07-21T21:20:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d1961/8188/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 812 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2525996
DQMHistoTests: Total failures: 4181
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2521768
DQMHistoTests: Total skipped: 47
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 144 log files, 17 edm output root files, 34 DQM output files

qliphy · 2020-07-22T02:14:58Z

+1

silviodonato · 2020-07-22T08:13:09Z

merge

Andrey added 3 commits June 8, 2020 16:46

Hydjet 1.9.1

64d7fa9

Full embedding mode for HI generators

be0c2b5

PYQUEN 1.5.4

c13bfb5

cmsbuild added this to the CMSSW_11_2_X milestone Jun 10, 2020

cmsbuild added code-checks-pending comparison-pending generators-pending operations-pending orp-pending pending-signatures simulation-pending tests-pending labels Jun 10, 2020

wouf changed the title ~~From cmssw 11 1 0 pre8~~ HYDJET, PYQUEN and new embedding Jun 10, 2020

wouf changed the title ~~HYDJET, PYQUEN and new embedding~~ HYDJET, PYQUEN and the new embedding Jun 10, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 10, 2020

This was referenced Jun 10, 2020

Access edm::event from GeneratorInterface #28636

Closed

Hydjet Interface External #28764

Closed

Update HydjetHadronizer.cc

281dcff

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 10, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 10, 2020

Update HydjetHadronizer.cc

5235688

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 10, 2020

cmsbuild added simulation-approved and removed simulation-pending labels Jul 15, 2020

cmsbuild added fully-signed operations-approved and removed operations-pending pending-signatures labels Jul 21, 2020

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Jul 21, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 21, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 21, 2020

cmsbuild mentioned this pull request Jul 21, 2020

Clean BuildFiles in GeneratorInterface #30866

Merged

cmsbuild added comparison-available and removed comparison-pending labels Jul 21, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 22, 2020

cmsbuild merged commit eea3e1a into cms-sw:master Jul 22, 2020

cmsbuild mentioned this pull request Jul 22, 2020

drop wrong default params in TLorentzVector in TestCorrections.C #30872

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HYDJET, PYQUEN and the new embedding #30185

HYDJET, PYQUEN and the new embedding #30185

wouf commented Jun 10, 2020 •

edited by silviodonato

cmsbuild commented Jun 10, 2020

cmsbuild commented Jun 10, 2020

cmsbuild commented Jun 10, 2020

cmsbuild commented Jun 10, 2020

silviodonato commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

silviodonato commented Jul 21, 2020 •

edited

cmsbuild commented Jul 21, 2020 •

edited

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

qliphy commented Jul 22, 2020

silviodonato commented Jul 22, 2020

HYDJET, PYQUEN and the new embedding #30185

HYDJET, PYQUEN and the new embedding #30185

Conversation

wouf commented Jun 10, 2020 • edited by silviodonato

PR description:

PR validation:

cmsbuild commented Jun 10, 2020

cmsbuild commented Jun 10, 2020

cmsbuild commented Jun 10, 2020

cmsbuild commented Jun 10, 2020

silviodonato commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

silviodonato commented Jul 21, 2020 • edited

cmsbuild commented Jul 21, 2020 • edited

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

qliphy commented Jul 22, 2020

silviodonato commented Jul 22, 2020

wouf commented Jun 10, 2020 •

edited by silviodonato

silviodonato commented Jul 21, 2020 •

edited

cmsbuild commented Jul 21, 2020 •

edited