Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated L1T tags to address CMSSW issue #29237 [11_1_X] #30190

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR is a backport of #30151. It is identical in content to the corresponding PR to master.

PR validation:

See the description of PR #30151 for details. In addition, a technical test was performed:

runTheMatrix.py -l limited,1325.516 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a backport of #30151. These updated conditions correct the L1T simulation for 2016 MC and these changes are needed to avoid the irreproducibility described in issue #29237.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2020

A new Pull Request was created by @christopheralanwest for CMSSW_11_1_X.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6955/console Started: 2020/06/11 14:42

@cmsbuild
Copy link
Contributor

+1
Tested at: 5e62881
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18b3fa/6955/summary.html
CMSSW: CMSSW_11_1_X_2020-06-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18b3fa/6955/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 622
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780120
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

  • GT difference identical to that in the corresponding PR to master
  • Same pattern of differences in the comparison tests as the PR to master

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@christopheralanwest
Copy link
Contributor Author

backport #30151

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 100178d into cms-sw:CMSSW_11_1_X Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants