Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to HCAL Run 3 conditions #30195

Merged

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR performs several updates to HCAL conditions for Run 3.

HB and HE have been recalibrated using isolated tracks. The energy scale needed adjustment after changes to the local HCAL reconstruction since 2019 and an asymmetry in the HB-HE transition region is fixed. The HcalRespCorrs are updated for all Run 3 scenarios.

In addition, HcalSiPMParameters, HcalPedestals, and HcalPedestalWidths have been updated for 2021 scenarios

2021 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_mcRun3_2021_design_v4/112X_mcRun3_2021_design_v1

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_mcRun3_2021_realistic_v4/112X_mcRun3_2021_realistic_v1

2021 cosmics (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_mcRun3_2021cosmics_realistic_deco_v4/112X_mcRun3_2021cosmics_realistic_deco_v1

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_mcRun3_2021_realistic_HI_v5/112X_mcRun3_2021_realistic_HI_v1

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_mcRun3_2023_realistic_v4/112X_mcRun3_2023_realistic_v1

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_mcRun3_2024_realistic_v4/112X_mcRun3_2024_realistic_v1

PR validation:

See the June 8 AlCaDB meeting (https://indico.cern.ch/event/927125/) and HN followup (https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4305/1/1.html) for details.

In addition, a technical test was performed:

runTheMatrix.py -l limited,7.23,159.0,12834.0 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport but may be backported to 11_1_X.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30195/16031

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

test parameters
workflow = 7.23,159.0,12834.0

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: dc852c0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea8290/6969/summary.html
CMSSW: CMSSW_11_2_X_2020-06-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea8290/6969/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ea8290/159.0_HydjetQ_B12_5020GeV_2021_ppReco+HydjetQ_B12_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RECOHI2021PPRECO+ALCARECOHI2021PPRECO+HARVESTHI2021PPRECO
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ea8290/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4286 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2779433
  • DQMHistoTests: Total failures: 17020
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2762363
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

  • conditions validated in local tests
  • changes in comparison tests seen only in expected workflows: 11634.0 and 12434.0. Small changes involving non-HCAL quantities are because of random number usage by the noise simulation in the digitizer

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants