Backport of UL scales and smearings to 106X

[jainshilpi]

This is essentially a backport of #29526
to 106X.

Just to mention the changes again:

(1) EnergyScaleCorrection.cc/h
(2) calibratedEgammas_cff.py

[cmsbuild]

A new Pull Request was created by @jainshilpi for CMSSW_10_6_X.

It involves the following packages:

RecoEgamma/EgammaTools

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@sobhatta, @afiqaize, @Sam-Harper, @varuns23, @lgray this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

• Backported from [RecoEgamma/EgammaTools] Updates to EnergyScaleCorrection class for scales and smearings in UL #29526

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6971/console Started: 2020/06/11 18:38

[perrotta]

backport of #29526

[cmsbuild]

+1
Tested at: 575f240
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea43ff/6971/summary.html
CMSSW: CMSSW_10_6_X_2020-06-11-1100
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea43ff/6971/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212324
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211971
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

@cmsbuild please test

to refresh the tests

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_10_6_X_2020-06-19-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7208/console Started: 2020/06/19 17:58

[cmsbuild]

+1
Tested at: 575f240
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea43ff/7208/summary.html
CMSSW: CMSSW_10_6_X_2020-06-19-1100
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea43ff/7208/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212264
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211927
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

+1

for #30199 575f240

• the backport is consistent with the final state of files in [RecoEgamma/EgammaTools] Updates to EnergyScaleCorrection class for scales and smearings in UL #29526
  • RecoEgamma/EgammaTools/interface/EnergyScaleCorrection.h and EnergyScaleCorrection.cc files are the same as in the master branch and include code-checks in addition with changes from [RecoEgamma/EgammaTools] Updates to EnergyScaleCorrection class for scales and smearings in UL #29526 proper
  • RecoEgamma/EgammaTools/python/calibratedEgammas_cff.py is updated minimally to pick up the new training for run2_miniAOD_devel
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1