Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added esConsumes to modules in EventFilter/EcalDigiToRaw #30201

Merged
merged 1 commit into from Jun 12, 2020

Conversation

JamminJones
Copy link
Contributor

PR description:

added esConsumes to 1 module

PR validation:

the code compiles

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@Dr15Jones
Copy link
Contributor

This change was made under my supervision

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30201/16040

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @JamminJones for master.

It involves the following packages:

EventFilter/EcalDigiToRaw

@mommsen, @cmsbuild, @emeschi can you please review it and eventually sign? Thanks.
@rchatter, @Martin-Grunewald, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 11, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6973/console Started: 2020/06/11 20:22

@cmsbuild
Copy link
Contributor

+1
Tested at: 5a5d88f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c981ad/6973/summary.html
CMSSW: CMSSW_11_2_X_2020-06-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c981ad/6973/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2779433
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2779382
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@mommsen
Copy link
Contributor

mommsen commented Jun 12, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 09ac9a5 into cms-sw:master Jun 12, 2020
@JamminJones JamminJones deleted the fixEventFilterEcalDigiToRaw branch July 27, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants