Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substantial clean-up of TrackerHitAssociator #3021

Merged
merged 8 commits into from Mar 26, 2014
Merged

Conversation

wmtford
Copy link
Contributor

@wmtford wmtford commented Mar 25, 2014

Per request from David Lange, remove all unused code.
Several rewrites to reduce duplication of code.
Streamline collection read-in (thanks to Danek).
Add the capability to specify PSimHit collections, rather than crossing-frame collections, via the ROUList in the config parameter set.
No other change in functionality; results match those of the previous PR for this class.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtford for CMSSW_7_1_X.

Substantial clean-up of TrackerHitAssociator

It involves the following packages:

SimTracker/TrackerHitAssociation

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Mar 26, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Mar 26, 2014
SIM -- Substantial clean-up of TrackerHitAssociator
@ktf ktf merged commit 444a788 into cms-sw:CMSSW_7_1_X Mar 26, 2014
@wmtford wmtford deleted the newAssoc branch May 1, 2014 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants