Move Cosmics During Collisions Reconstruction to ALCARECO

[mmusich]

PR description:

The goal of this PR is two-fold:

• move the CDC (Cosmics During Collisions) reconstruction out of the standard (p-p) reconstruction sequence and include it into the TkAlCosmicsInCollisions ALCARECO. This in turn allows to freely change the parameters in order to optimize for efficiency / acceptance at the cost of increase of timing, as the ALCARECO will be run only on the NoBPTX dataset and not in dense events where the seeding and candidate building explodes.
• thanks to the first point, the seeding and track building parameters have been optimized. Optimization has been done in order to increase the reconstruction efficiency of real interfill cosmics tracks undergoing the CDC reco.

PR validation:

The results of the parameter optimization have been presented here. The setup chosen here is corresponding to TEST13.
Detailed timing studies on the various setups have been produced by @mtosi and are collected in this spreadsheet.

This branch has also been technically tested by running the following command.

cmsDriver.py stepTest --conditions auto:run2_data -s RAW2DIGI,L1Reco,RECO,ALCA:TkAlCosmicsInCollisions --process reRECO --data --era Run2_2018 --eventcontent RECO,ALCARECO --scenario pp --datatier RECO,ALCARECO --customise Configuration/DataProcessing/RecoTLR.customisePostEra_Run2_2018 -n 10000 --dasquery='file dataset=/NoBPTX/Run2018B-v1/RAW site=T2_CH_CERN' --nThreads=8 --no_exec

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport.
cc:
@mtosi, @connorpa @vbotta

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30248/16145

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/StandardSequences/python/Reconstruction_cff.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, HCAL only wf #30136

[mmusich]

@cmsbuild please test workflow 136.735, 136.803, 136.894

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 136.803,136.894,136.735
• CMSSW_11_2_X_2020-06-15-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7083/console Started: 2020/06/15 18:58

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Alignment/CommonAlignmentProducer
Configuration/StandardSequences
RecoTracker/Configuration
RecoTracker/SpecialSeedGenerators

@perrotta, @silviodonato, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@pakhotin, @fabiocos, @adewit, @makortel, @felicepantaleo, @GiacomoSguazzoni, @tocheng, @VinInn, @Martin-Grunewald, @mschrode, @ebrondol, @rovere, @lecriste, @tlampen, @gpetruc, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: c885a6e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b492ba/7083/summary.html
CMSSW: CMSSW_11_2_X_2020-06-15-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b492ba/7083/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b492ba/136.735_RunNoBPTX2016B+RunNoBPTX2016B+HLTDR2_2016+RECODR2reHLTAlCaTkCosmics_HIPM+HARVESTDR2
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b492ba/136.803_RunNoBPTX2017C+RunNoBPTX2017C+HLTDR2_2017+RECODR2_2017reHLTAlCaTkCosmics_Prompt+HARVEST2017
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b492ba/136.894_RunNoBPTX2018D+RunNoBPTX2018D+HLTDR2_2018+RECODR2_2018reHLTAlCaTkCosmics_Prompt+HARVEST2018_Prompt

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 188 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778811
• DQMHistoTests: Total failures: 316
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778445
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[mtosi]

CPU timing measurement on CDC events from run 324897 gives the following

• cosmicDCSeeds : 8.2 ms
• cosmicDCCkfTrackCandidates : 9.1 ms
• cosmicDCTracks : 0.5 ms

[pohsun]

+1

[silviodonato]

+operations

[slava77]

+1

for #30248 c885a6e

• code changes are in line with the PR description
• jenkins tests pass and comparisons with the baseline show differences only related to the move/removal of cosmicDCTracks producer/products

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1