embed hi photon isolation in pat::photon userdata #30255

bi-ran · 2020-06-15T21:36:56Z

this PR takes the HI-style photon isolation information, which are stored in RECO as valuemaps, and adds it to the userdata of the PAT photons. the change is applied to the pp_on_AA_2018 and pp_on_PbPb_run3 eras.

the existing code is modified slightly to allow the reco::Photon collection to also be used as input, because the isolation valuemaps are keyed by that collection. the changes should not affect usage in pp, since edm::View allows both reco:: and pat:: collections to be read.

tested with the 158/159 workflows that the information can be stored and read out.

@mandrenguyen

for the pp_on_AA_2018 era. change pat:: types to reco:: types to allow using reco:: collections as input.

cmsbuild · 2020-06-15T21:37:15Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-15T21:44:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30255/16157

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoEgamma/EgammaTools/interface/EGExtraInfoModifierFromValueMaps.h modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

cmsbuild · 2020-06-15T21:44:37Z

A new Pull Request was created by @bi-ran for master.

It involves the following packages:

RecoEgamma/EgammaTools

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @lgray, @sobhatta, @afiqaize, @varuns23 this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

perrotta · 2020-06-16T10:54:11Z

please test

cmsbuild · 2020-06-16T10:54:41Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-15-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7100/console Started: 2020/06/16 14:01

cmsbuild · 2020-06-16T13:21:48Z

+1
Tested at: 576b8bd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e579c5/7100/summary.html
CMSSW: CMSSW_11_2_X_2020-06-15-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-16T13:21:51Z

Comparison job queued.

cmsbuild · 2020-06-16T15:22:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e579c5/7100/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778811
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778754
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

perrotta · 2020-06-24T15:06:50Z

please test
(to refresh the tests)

cmsbuild · 2020-06-30T13:53:27Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #30354
Test Parameters:

MATRIX_EXTRAS = 140.5611

perrotta · 2020-07-01T10:59:02Z

+1

The new isolation selection for PAT photons in Run3 HI has been compared with the current one thanks to the new HI re-miniAOD workflows defined with reMiniAOD relval workflows for heavy ions #30354: the size of slimmed photons is significantly reduced with this selection with respect to the one that would have been obtained with the standard (pp) selection
Changes in the reco code are instrumental to apply them to reco objects, instead of only candidates, but they have no effect on the other standard workflows
Jenkins tests pass and show no differences anywhere else than in the HI re-miniAOD

cmsbuild · 2020-07-01T10:59:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-07-02T08:48:37Z

+1

perrotta · 2020-07-02T13:20:22Z

@cmsbuild please test workflow 140.5611
(this will hopefully unblock bot)

cmsbuild · 2020-07-02T13:20:48Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 140.5611
CMSSW_11_2_X_2020-07-01-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7605/console Started: 2020/07/02 15:27

cmsbuild · 2020-07-02T14:52:25Z

+1
Tested at: 576b8bd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e579c5/7605/summary.html
CMSSW: CMSSW_11_2_X_2020-07-01-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-02T14:52:28Z

Comparison job queued.

cmsbuild · 2020-07-02T16:52:19Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e579c5/7605/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2784120
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2784064
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
Checked 154 log files, 17 edm output root files, 37 DQM output files

bi-ran added 2 commits June 15, 2020 21:33

add hi photon isolation to pat::photon userdata

b33eae1

for the pp_on_AA_2018 era. change pat:: types to reco:: types to allow using reco:: collections as input.

enable changes in run3 era as well

576b8bd

cmsbuild added this to the CMSSW_11_2_X milestone Jun 15, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 15, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 15, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 16, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 16, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 16, 2020

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Jun 24, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 30, 2020

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Jul 1, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 2, 2020

cmsbuild added tests-pending and removed tests-started labels Jul 2, 2020

cmsbuild added tests-started and removed requires-external tests-pending labels Jul 2, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 2, 2020

cmsbuild merged commit d3345ee into cms-sw:master Jul 2, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 2, 2020

This was referenced Jul 2, 2020

Phase2 L1 ParticleFlow #30510

Merged

fix compilation with EDM_ML_DEBUG in Geometry/HGCalGeometry/src/HGCalGeometry.cc #30513

Merged

ttrk mentioned this pull request Dec 11, 2020

HIPhotonIsolation not correctly added to pat::photon #32451

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

embed hi photon isolation in pat::photon userdata #30255

embed hi photon isolation in pat::photon userdata #30255

bi-ran commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

perrotta commented Jun 16, 2020

cmsbuild commented Jun 16, 2020 •

edited

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

perrotta commented Jun 24, 2020

cmsbuild commented Jun 30, 2020

perrotta commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

silviodonato commented Jul 2, 2020

perrotta commented Jul 2, 2020

cmsbuild commented Jul 2, 2020 •

edited

cmsbuild commented Jul 2, 2020

cmsbuild commented Jul 2, 2020

cmsbuild commented Jul 2, 2020

embed hi photon isolation in pat::photon userdata #30255

embed hi photon isolation in pat::photon userdata #30255

Conversation

bi-ran commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

cmsbuild commented Jun 15, 2020

perrotta commented Jun 16, 2020

cmsbuild commented Jun 16, 2020 • edited

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

perrotta commented Jun 24, 2020

cmsbuild commented Jun 30, 2020

perrotta commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

silviodonato commented Jul 2, 2020

perrotta commented Jul 2, 2020

cmsbuild commented Jul 2, 2020 • edited

cmsbuild commented Jul 2, 2020

cmsbuild commented Jul 2, 2020

cmsbuild commented Jul 2, 2020

cmsbuild commented Jun 16, 2020 •

edited

cmsbuild commented Jul 2, 2020 •

edited