Keep GEMDigiSimLinks after the DIGI step

[dildick]

PR description:

RAW and RECO simulated data currently keep the StripDigiSimLink objects for GEMs. They are actually not that useful. However, the GEMDigiSimLink is much more useful as it properly links the GEM SimHit with the GEMDigi This PR adds it to the event content after the DIGI step. The size is about the same as the StripDigiSimLink. After running WF 23234.0:

-bash-4.2$ edmEventSize -a -v step2.root | grep GEM
GEMDigiSimLinkedmDetSetVector_simMuonME0Digis_ME0_HLT. 15540 5387.4
GEMDigiSimLinkedmDetSetVector_simMuonGEMDigis_GEM_HLT. 14341 4546.3
StripDigiSimLinkedmDetSetVector_simMuonGEMDigis_GEM_HLT. 14279.2 4508.1

If the GEMDigiSimLink takes up too much space, I would propose to drop StripDigiSimLink, which is not used in the simulation AFAIK.

PR validation:

Tested with WF 23234.0

@jshlee

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30257/16159

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

SimMuon/Configuration

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@battibass, @folguera, @abbiendi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @cericeci, @trocino, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-16-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7127/console Started: 2020/06/17 09:56

[cmsbuild]

+1
Tested at: 01cd331
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75b1b0/7127/summary.html
CMSSW: CMSSW_11_2_X_2020-06-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75b1b0/7127/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778811
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778760
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[civanch]

+1

@dildick , if StripDigiSimLink is not used, then drop it with the next occasion independently on size

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1
fyi @perrotta @slava77