Including PPS into cmsExtended 2021

[mundim]

Integrates PPS geometry into the cmsExtendedGeometry2021

PR description:

Follow up from PR #29916, where it was decided to integrate PPS as part of the extended geometry.

PR validation:

All tests were done without ANY issues, all runTheMatrix completed.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30268/16193

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml modified in PR(s): [DD4hep] Update DD4hep 2021 Scenario #30208
  • File Geometry/CMSCommonData/python/cmsExtendedGeometry2021XML_cfi.py modified in PR(s): PPS Full simulation integration #29916
  • File Geometry/VeryForwardData/data/pps/2021/v1/pps.xml modified in PR(s): PPS Full simulation integration #29916

[cmsbuild]

A new Pull Request was created by @mundim for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData
Geometry/VeryForwardData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@vargasa, @forthommel, @jan-kaspar, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[ianna]

Please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-16-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7123/console Started: 2020/06/17 08:52

[cmsbuild]

+1
Tested at: ae6247e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2182fb/7123/summary.html
CMSSW: CMSSW_11_2_X_2020-06-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2182fb/7123/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778811
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778760
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[cvuosalo]

+1

[civanch]

@kpedro88 , please, check this PR

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[makortel]

It could be that this PR caused 6 unit tests to fail, see #30298.

[mundim]

Before issuing the PR, I ran all tests and in my working area, none failed. Is there anything I need to do? Could it have something with #30292? After the merge, I reused the same branch, could that be the cause of the problems?

[makortel]

Right, I noticed the discussion in cms-sw/cmsdist#5954 only now. It's the same issue so presumably #30292 is the fix.

[mundim]

Great. Let me know if I need to do anything else.