Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated L1T tags to address CMSSW issue #29237 [10_6_X] #30287

Conversation

christopheralanwest
Copy link
Contributor

PR description:

In principle, this is just a backport of PR #30151. But it also corresponds to the GT content already in use in the 2016 UL production:

In addition, a corresponding cosmic GT is provided.

The GT diffs with respect to the previous version are the same for each of the three GTs:

2016 pre-VFP asymptotic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun2_asymptotic_preVFP_v3/106X_mcRun2_asymptotic_preVFP_v8

2016 post-VFP asymptotic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun2_asymptotic_v9/106X_mcRun2_asymptotic_v13

2016 cosmics (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun2cosmics_startup_deco_v6/106X_mcRun2cosmics_startup_deco_v7

PR validation:

See PR #30151 for details. In addition, a technical test was performed:

runTheMatrix.py -l limited,7.22 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of PR #30151.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @christopheralanwest for CMSSW_10_6_X.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

test parameters
workflow = 7.22

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 17, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 73f22c3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da7c60/7166/summary.html
CMSSW: CMSSW_10_6_X_2020-06-17-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da7c60/7166/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-da7c60/7.22_Cosmics_UP16+Cosmics_UP16+DIGICOS_UP16+RECOCOS_UP16+ALCACOS_UP16+HARVESTCOS_UP16

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 640
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211350
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@tlampen
Copy link
Contributor

tlampen commented Jun 18, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 891cf9c into cms-sw:CMSSW_10_6_X Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants