Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding eval=true in ConstantsSection in all PPS xml files #30292

Merged
merged 4 commits into from Jun 24, 2020

Conversation

mundim
Copy link
Contributor

@mundim mundim commented Jun 18, 2020

PR description:

Adding eval="true" in the PPS xml files, as requested in

cms-sw/cmsdist#5954 (comment)

PR validation:

Tests passed and the new files were tested again in the PPS simulation, producing properly the hits as expected.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30292/16244

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mundim for master.

It involves the following packages:

Geometry/VeryForwardData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@forthommel, @jan-kaspar, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 18, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: bb06069
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9f499/7189/summary.html
CMSSW: CMSSW_11_2_X_2020-06-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9f499/7189/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2778811
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2778760
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@smuzaffar
Copy link
Contributor

I have restart the test with DetectorDescription/DDCMS Geometry/DTGeometryBuilder SimG4Core/DD4hepGeometry extra package to be build along with this PR. Looks like this did not fix the unit test issue. Test still fail with error

===== Test "testDD4hepCompactView" ====
Running .Info in <TGeoManager::TGeoManager>: Geometry DUMMY, Detector Geometry created
PersistencyIO    INFO  +++ Set Streamer to dd4hep::OpaqueDataBlock
CompactLoader    INFO  +++ Processing compact file: /cvmfs/cms-ib.cern.ch/nweek-02633/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-06-18-2300/src/Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml with flag (null)
DD4CMS           INFO  +++ Processing the CMS detector description file:///cvmfs/cms-ib.cern.ch/nweek-02633/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-06-18-2300/src/Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml
Info in <TGeoManager::SetTopVolume>: Top volume is world_volume. Master volume is world_volume
Info in <TGeoNavigator::BuildCache>: --- Maximum geometry depth set to 100
Detector         INFO  *********** Created World volume with size: 10100 10100 45000
DD4CMS           ERROR Exception while processing xml source:file:///data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-18-2300/src/Geometry/VeryForwardData/data/RP_Hybrid.xml
DD4CMS           ERROR ----> Cannot find a material referenced by name:RP_Materials:CE7
dd4hep: Error interpreting XML nodes of type <LogicalPart/>
dd4hep: Error interpreting XML nodes of type <LogicalPartSection/>
E

##Failure Location unknown## : Error
Test name: testDDCompactView::checkCompactView
uncaught exception of type std::exception (or derived).
- Cannot find a material referenced by name:RP_Materials:CE7
dd4hep: Error interpreting XML nodes of type <LogicalPart/>
dd4hep: Error interpreting XML nodes of type <LogicalPartSection/>
dd4hep: while parsing /cvmfs/cms-ib.cern.ch/nweek-02633/slc7_amd64_gcc820/cms/c
mssw-patch/CMSSW_11_2_X_2020-06-18-2300/src/Geometry/CMSCommonData/data/dd4hep/
cmsExtendedGeometry2021.xml
dd4hep: with plugin:DD4hep_CompactLoader

Failures !!!
Run: 1   Failure total: 1   Failures: 0   Errors: 1

---> test testDD4hepCompactView had ERRORS

@smuzaffar
Copy link
Contributor

@mundim, did you actuall checkout DetectorDescription/DDCMS Geometry/DTGeometryBuilder SimG4Core/DD4hepGeometry while testing locally?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9f499/7306/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2778811
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2778757
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@mundim
Copy link
Contributor Author

mundim commented Jun 24, 2020

The tests are being triggered in jenkins.
Test Parameters:

* **EXTRA_CMSSW_PACKAGES** = Geometry/DTGeometryBuilder,DetectorDescription/DDCMS,SimG4Core/DD4hepGeometry

* CMSSW_11_2_X_2020-06-23-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7313/console Started: 2020/06/24 11:50

Sorry, it was not my intention to include these packages in the branch. Is it a problem?

@smuzaffar
Copy link
Contributor

No it is not a problem, you did the right thing.
As we know that the unit tests of these 3 cmssw packages depend on the changes of this PR, so we wanted to make sure that PR test actually checkout these packages and run tests. That is why I added the extra test parameter here.

@smuzaffar
Copy link
Contributor

smuzaffar commented Jun 24, 2020

by the way, looks like your latest changes have fixed the issue.

@cmsbuild
Copy link
Contributor

+1
Tested at: ab431ab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9f499/7313/summary.html
CMSSW: CMSSW_11_2_X_2020-06-23-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@ianna
Copy link
Contributor

ianna commented Jun 24, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f18f5a7 into cms-sw:master Jun 24, 2020
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9f499/7313/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2778811
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2778760
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@mundim
Copy link
Contributor Author

mundim commented Jun 24, 2020

Thanks a lot to everyone who helped on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants