Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for incorrect Run 3 HLT JEC [11_0_X] #30300

Merged

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR is a backport of PR #30221. The GT diffs are the same as in the PR to master.

Negative HLT jet energies have been reported in Run-3 samples. The problem has been traced to the fact that Run-3 GTs currently load the 2016 HLT JECs, while it should actually make use of the 2017 HLT JECs.

2021 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2021_design_v7/110X_mcRun3_2021_design_v8

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2021_realistic_v9/110X_mcRun3_2021_realistic_v10

2021 cosmic (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2021cosmics_realistic_deco_v6/110X_mcRun3_2021cosmics_realistic_deco_v7

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2023_realistic_v9/110X_mcRun3_2023_realistic_v10

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_mcRun3_2023_realistic_v9/110X_mcRun3_2023_realistic_v10

Note that the 2021 heavy ion scenario was introduced in 11_1_X, so there is no 2021 heavy ion GT here.

PR validation:

Tests were performed with a candidate GT to ensure that the fix behaves as expected.

See the following presentations for details:

https://indico.cern.ch/event/915728/contributions/3850261/subcontributions/305633/attachments/2045906/3431055/200527_jme_hltJECs.pdf
https://cernbox.cern.ch/index.php/s/L6Sxh48hsyhq2m0

In addition, a technical test is performed:

runTheMatrix.py -l limited,7.23,12834.0 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a backport of #30221. It is needed because the HLT JEC conditions currently used in the Run-3 GTs are incorrect.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 19, 2020

A new Pull Request was created by @christopheralanwest for CMSSW_11_0_X.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

backport #30221

@christopheralanwest
Copy link
Contributor Author

test parameters
workflow = 7.23,12834.0

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 19, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 282d960
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-836d09/7198/summary.html
CMSSW: CMSSW_11_0_X_2020-06-18-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-836d09/7198/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-836d09/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 2503
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2790996
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

  • Identical GT diff as in PR to master
  • Changes validated in local tests
  • Comparison tests show differences only in expected workflows (11634.0 and 12434.0) and only in the expected histograms (HLT histograms only)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants