Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added esConsumes to modules in L1Trigger /L1ExtraFromDigis #30336

Merged
merged 2 commits into from Jul 7, 2020

Conversation

JamminJones
Copy link
Contributor

PR description:

added esConsumes to 1 module

PR validation:

the code compiles

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30336/16339

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @JamminJones for master.

It involves the following packages:

L1Trigger/L1ExtraFromDigis

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

This code change was made under my supervision.

@Dr15Jones
Copy link
Contributor

hold

the EventSetup gets are done conditionally so we should set the tokens conditionally as well.

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @Dr15Jones
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Jun 22, 2020
esHandles were only being used based on the module parameters. Now the associated tokens are only set based on the same parameters.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30336/16357

@cmsbuild
Copy link
Contributor

Pull request #30336 was updated. @cmsbuild, @rekovic, @benkrikler can you please check and sign again.

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 23, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: f86503b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0ddd9/7292/summary.html
CMSSW: CMSSW_11_2_X_2020-06-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Dr15Jones
Copy link
Contributor

unhold

@cmsbuild cmsbuild removed the hold label Jun 23, 2020
@Dr15Jones
Copy link
Contributor

NOTE: The new code conditionally calls esConsumes based on the conditional getting of the data from the EventSetup. This was done to avoid prefetching of EventSetup data that will not be needed.

Looking at the existing consumes calls, many of them should also be conditional as the configuration parameters set which Event data will actually be requested. Not calling consumes conditionally is requiring the framework to prefetch Event data which is not needed.

I suggest that the maintainers of this code modify the consumes calls to only be called if needed.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0ddd9/7292/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2778811
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2778757
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@Dr15Jones
Copy link
Contributor

ping

@Dr15Jones
Copy link
Contributor

ping (it has been 2 weeks now without a review)

@rekovic
Copy link
Contributor

rekovic commented Jul 7, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants