added esConsumes to modules in RecoLocalMuon/GEMRecHit

[JamminJones]

PR description:

added esConsumes to 2 modules

PR validation:

the code compiles

[cmsbuild]

The code-checks are being triggered in jenkins.

[Dr15Jones]

The change was made under my supervision.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30450/16580

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalMuon/GEMRecHit/plugins/GEMRecHitProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935

[cmsbuild]

A new Pull Request was created by @JamminJones for master.

It involves the following packages:

RecoLocalMuon/GEMRecHit

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@jshlee, @bellan, @jhgoh this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-29-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7490/console Started: 2020/06/29 17:36

[cmsbuild]

+1
Tested at: 7021f95
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-83d5b9/7490/summary.html
CMSSW: CMSSW_11_2_X_2020-06-29-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-83d5b9/7490/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778915
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2778859
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 35 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[slava77]

+1

for #30450 7021f95

• code changes are in line with the PR description
  • this is still partial, since the ES access in the helper class theAlgo is still to be tokenized
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[Dr15Jones]

@slava77

this is still partial, since the ES access in the helper class theAlgo is still to be tokenized

That would be bad since a module must always use tokens or never use tokens, it can't have a combination else we generate an exception. I took a look at theAlgo and although it has the ability to get the EventSetup, none of its concrete implementations does so.

My suggestion is to either

1. remove the setES function in the base class or
2. require the constuctors take an edm::ConsumesCollector.

[slava77]

That would be bad since a module must always use tokens or never use tokens, it can't have a combination else we generate an exception.

Interesting, I thought that it was more like the ED consumes integration (IIRC, until some switch was flipped, the code with and without consumes would work).
I guess this means that in this case theAlgo is actually not consuming anything new

[Dr15Jones]

@slava77

I guess this means that in this case theAlgo is actually not consuming anything new

It is not consuming anything at all :) (I checked.)

[Dr15Jones]

@slava77 The migrations to using esConsumes actually requires that all get calls in the EventSetup system for a given module must use a token. If an attempt is made using a call without a token (and the module has registered at least one esConsumes) then an exception will be thrown. This guarantees that once a module is converted to using tokens, one can't accidently add any old school get calls.