PPS: direct simulation update A

[jan-kaspar]

PR description:

Several updates to the "direct" simulation of PPS have been presented in the PPS General Meeting:
https://indico.cern.ch/event/927936/contributions/3909004/attachments/2057769/3451230/kaspar_GM_direct_simu.pdf
This PR contains a first part of them (thus the A in the name). Others will follow once the Run3 geometry and RP layout are in place, cf. #30252.

This PR contains the following updates

• simulation of timing RPs (diamonds)
• the previously single 2018 profile (settings) is replaced with 3 profiles, each reflecting one position of the pixel RPs (moved vertically during TS1 and TS2)
• the latest optical functions are used (those foreseen for the Run2 re-miniAOD), cf. Optical functions for Run2 re-miniAOD and a guess for Run3. cms-data/CalibPPS-ESProducers#3

The "direct" simulation is not used in any central workflow, thus no change in these WFs is expected.

PR validation:

Several validation plots are available in the PPS GM talk linked in the beginning.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30466/16622

• This PR adds an extra 60KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/Eras/python/Era_Run3_cff.py modified in PR(s): PPS Full simulation integration #29916
  • File IOMC/EventVertexGenerators/src/BeamDivergenceVtxGenerator.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File Validation/CTPPS/plugins/CTPPSProtonReconstructionPlotter.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934

[cmsbuild]

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

CalibPPS/ESProducers
CondFormats/PPSObjects
Configuration/Eras
IOMC/EventVertexGenerators
Validation/CTPPS

@andrius-k, @kmaeshima, @schneiml, @christopheralanwest, @civanch, @mdhildreth, @cmsbuild, @silviodonato, @franzoni, @jfernan2, @fioriNTU, @tlampen, @tocheng, @pohsun, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @forthommel, @tocheng, @Martin-Grunewald, @mmusich, @fabiocos, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-29-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7525/console Started: 2020/06/30 16:12

[cmsbuild]

+1
Tested at: 83c4850
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c73c4/7525/summary.html
CMSSW: CMSSW_11_2_X_2020-06-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[jfernan2]

+1

[tlampen]

+1

[civanch]

+1

[jan-kaspar]

@davidlange6, @fabiocos, @franzoni, @silviodonato: could you please check (and possibly sign off) the small change in Era_Run3_cff.py? It simply replaces the inapplicable ctpps_2018 (Run2) with more appropriate ctpps_2021. Many thanks in advance!

[silviodonato]

+operations

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1