[HGC trigger] Update mapping for V11 #30470

jbsauvan · 2020-06-30T14:44:26Z

FYI @kpedro88 @silviodonato @rekovic @bsunanda

PR description:

Updated mapping for V11 after the changes in the cell validity checks implemented in #30323

Depends on external cms-data/L1Trigger-L1THGCal#19
Since PR #30323 has been reverted, it should be tested with #30467 + re-enable of L1T HGCAL in V11 (since it is disabled in #30467).

PR validation:

Minimal checks with the V11 geometry including the #30323 updates

cmsbuild · 2020-06-30T14:44:55Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-30T14:51:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30470/16629

This PR adds an extra 12KB to repository

cmsbuild · 2020-06-30T14:52:05Z

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master.

It involves the following packages:

L1Trigger/L1THGCal

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @lgray this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

mrodozov · 2020-06-30T15:37:19Z

test parameters:

pull_request = Update module mapping for V11 cms-data/L1Trigger-L1THGCal#19

silviodonato · 2020-06-30T16:20:24Z

please test with #30473, cms-data/L1Trigger-L1THGCal#19

cmsbuild · 2020-06-30T16:20:50Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #30473,cms-data/L1Trigger-L1THGCal#19

CMSSW_11_2_X_2020-06-30-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7537/console Started: 2020/06/30 18:36

cmsbuild · 2020-06-30T19:21:28Z

-1

Tested at: d428199

CMSSW: CMSSW_11_2_X_2020-06-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Add all direct deps to BuildFile for CondCore/Utilities #30378 @davidlange6: Add all direct deps to BuildFile for CondCore/Utilities
Add all direct deps to BuildFile for CondFormats/HLTObjects #30379 @davidlange6: Add all direct deps to BuildFile for CondFormats/HLTObjects
Add all direct deps to BuildFile for CondFormats/SiPixelObjects #30381 @davidlange6: Add all direct deps to BuildFile for CondFormats/SiPixelObjects
Add all direct deps to BuildFile for Alignment/CocoaFit #30461 @davidlange6: Add all direct deps to BuildFile for Alignment/CocoaFit
Add all direct deps to BuildFile for CondFormats/SiStripObjects #30382 @davidlange6: Add all direct deps to BuildFile for CondFormats/SiStripObjects

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a0fb/7537/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a0fb/7537/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a0fb/7537/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
23234.0 step2

runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Add all direct deps to BuildFile for CondCore/Utilities #30378 @davidlange6: Add all direct deps to BuildFile for CondCore/Utilities
Add all direct deps to BuildFile for CondFormats/HLTObjects #30379 @davidlange6: Add all direct deps to BuildFile for CondFormats/HLTObjects
Add all direct deps to BuildFile for CondFormats/SiPixelObjects #30381 @davidlange6: Add all direct deps to BuildFile for CondFormats/SiPixelObjects
Add all direct deps to BuildFile for Alignment/CocoaFit #30461 @davidlange6: Add all direct deps to BuildFile for Alignment/CocoaFit
Add all direct deps to BuildFile for CondFormats/SiStripObjects #30382 @davidlange6: Add all direct deps to BuildFile for CondFormats/SiStripObjects

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a0fb/7537/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a0fb/7537/git-merge-result

cmsbuild · 2020-06-30T19:21:37Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

jbsauvan · 2020-06-30T20:03:21Z

That's strange, the wafer causing the error seems to be in the mapping file. I have to look in more details

jbsauvan · 2020-07-01T07:27:43Z

@kpedro88
The V11 mappings are actually not correctly loaded. The V9 mappings are loaded instead.
The customization is done here:

cmssw/L1Trigger/L1THGCal/python/hgcalTriggerPrimitives_cff.py

Lines 25 to 26 in b0ddd4e

    
           modifyHgcalTriggerPrimitivesWithV9Geometry_ = phase2_hgcalV9.makeProcessModifier(custom_geometry_decentralized_V9) 
        
           modifyHgcalTriggerPrimitivesWithV11Geometry_ = phase2_hgcalV11.makeProcessModifier(custom_geometry_decentralized_V11)

But adding some printouts in the customization functions I see that first the V11 customization is called, followed by a call to the V9 customization (which erases the V11 customization).
It may be due to the order eras modifiers are called, but I don't know enough about that to conclude exactly what's going on.

cmsbuild · 2020-07-01T14:15:40Z

The code-checks are being triggered in jenkins.

jbsauvan · 2020-07-01T14:18:28Z

Thanks @kpedro88 I've changed the V9 modifier as suggested and it seems to work now.

cmsbuild · 2020-07-01T14:20:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30470/16654

This PR adds an extra 16KB to repository

cmsbuild · 2020-07-01T14:20:29Z

Pull request #30470 was updated. @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please check and sign again.

silviodonato · 2020-07-01T16:12:00Z

please test with #30473, cms-data/L1Trigger-L1THGCal#19

cmsbuild · 2020-07-01T16:12:17Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #30473,cms-data/L1Trigger-L1THGCal#19

CMSSW_11_2_X_2020-06-30-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7563/console Started: 2020/07/01 18:14

cmsbuild · 2020-07-01T18:08:04Z

+1
Tested at: 3df3679
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a0fb/7563/summary.html
CMSSW: CMSSW_11_2_X_2020-06-30-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-01T18:08:13Z

Comparison job queued.

cmsbuild · 2020-07-01T19:59:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a0fb/7563/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2784120
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2784069
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 154 log files, 17 edm output root files, 37 DQM output files

silviodonato · 2020-07-01T20:45:44Z

merge

kpedro88 · 2020-07-01T20:46:44Z

+upgrade

Update mapping for V11

d428199

cmsbuild added this to the CMSSW_11_2_X milestone Jun 30, 2020

cmsbuild added code-checks-pending comparison-pending l1-pending orp-pending pending-signatures tests-pending upgrade-pending labels Jun 30, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 30, 2020

This was referenced Jun 30, 2020

Restore "Run4-hgx247 Add some new features for HGCal" (#30323) #30473

Merged

Update module mapping for V11 cms-data/L1Trigger-L1THGCal#19

Merged

cmsbuild added requires-external tests-started and removed tests-pending labels Jun 30, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jun 30, 2020

cmsbuild added code-checks-pending comparison-pending tests-pending labels Jul 1, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 1, 2020

cmsbuild added requires-external tests-started and removed tests-pending labels Jul 1, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 1, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 1, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 1, 2020

cmsbuild merged commit fd1c5fa into cms-sw:master Jul 1, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 1, 2020

silviodonato mentioned this pull request Jul 3, 2020

[HGC trigger] Update mapping for V11 (backport 11_1_X) #30516

Merged

jbsauvan mentioned this pull request Nov 29, 2021

Archived Integrations hgc-tpg/cmssw#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HGC trigger] Update mapping for V11 #30470

[HGC trigger] Update mapping for V11 #30470

jbsauvan commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

mrodozov commented Jun 30, 2020

silviodonato commented Jun 30, 2020

cmsbuild commented Jun 30, 2020 •

edited

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

jbsauvan commented Jun 30, 2020

jbsauvan commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

jbsauvan commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

silviodonato commented Jul 1, 2020

cmsbuild commented Jul 1, 2020 •

edited

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

silviodonato commented Jul 1, 2020

kpedro88 commented Jul 1, 2020

Navigation Menu

[HGC trigger] Update mapping for V11 #30470

[HGC trigger] Update mapping for V11 #30470

Conversation

jbsauvan commented Jun 30, 2020

PR description:

PR validation:

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

mrodozov commented Jun 30, 2020

silviodonato commented Jun 30, 2020

cmsbuild commented Jun 30, 2020 • edited

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

jbsauvan commented Jun 30, 2020

jbsauvan commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

jbsauvan commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

silviodonato commented Jul 1, 2020

cmsbuild commented Jul 1, 2020 • edited

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

cmsbuild commented Jul 1, 2020

silviodonato commented Jul 1, 2020

kpedro88 commented Jul 1, 2020

cmsbuild commented Jun 30, 2020 •

edited

cmsbuild commented Jul 1, 2020 •

edited