Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganise HLTrigger/Timer utilities (11.1.x) #30471

Merged
merged 6 commits into from Jun 30, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jun 30, 2020

PR description:

Reorganise the memory_usage and processor_model utilities:

  • move the code from the plugin to the library
  • add unit tests
  • implement experimental support for monitoring per-thread peak memory usage with jemalloc

PR validation:

Unit tests compile, run, and give the expected results.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 30, 2020

backport #29970

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 30, 2020

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_11_1_X.

It involves the following packages:

HLTrigger/Timer

@cmsbuild, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 30, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 30, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 30, 2020

@cmsbuild, please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 30, 2020

@silviodonato this is the CMSSW PR that goes with cms-sw/cmsdist#5897

@cmsbuild
Copy link
Contributor

+1
Tested at: c1ab3b1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-076d4b/7532/summary.html
CMSSW: CMSSW_11_1_X_2020-06-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-076d4b/7532/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780740
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0da3b26 into cms-sw:CMSSW_11_1_X Jun 30, 2020
@fwyzard fwyzard deleted the HLTrigger_Timer_Utilities branch July 13, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants