Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HGC trigger] Update mapping for V11 (backport 11_1_X) #30516

Merged
merged 2 commits into from Jul 3, 2020
Merged

[HGC trigger] Update mapping for V11 (backport 11_1_X) #30516

merged 2 commits into from Jul 3, 2020

Conversation

silviodonato
Copy link
Contributor

@silviodonato silviodonato commented Jul 3, 2020 •
edited

Backport of #30470

PR description of #30470:

Updated mapping for V11 after the changes in the cell validity checks implemented in #30323

Depends on external cms-data/L1Trigger-L1THGCal#19
Since PR #30323 has been reverted, it should be tested with #30467 + re-enable of L1T HGCAL in V11 (since it is disabled in #30467).

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone Jul 3, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020 •
edited

A new Pull Request was created by @silviodonato (Silvio Donato) for CMSSW_11_1_X.

It involves the following packages:

L1Trigger/L1THGCal

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @jbsauvan, @lgray this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

@jbsauvan @bsunanda Could you confirm that we need to backport #30467? I'm trying to do it but it is not trivial. Could you have a look?

@silviodonato
Copy link
Contributor Author

please test with cms-data/L1Trigger-L1THGCal#19

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/L1Trigger-L1THGCal#19

@cmsbuild cmsbuild mentioned this pull request Jul 3, 2020
Merged
@jbsauvan
Copy link
Contributor

jbsauvan commented Jul 3, 2020

In principle this PR should work even without #30467. But I'm not sure what #30467 brings in addition to the cell validity criteria and whether it can be backported.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

+1
Tested at: d1bdc5a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a69e59/7637/summary.html
CMSSW: CMSSW_11_1_X_2020-07-02-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

Comparison job queued.

@silviodonato
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit c3b29da into cms-sw:CMSSW_11_1_X Jul 3, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a69e59/7637/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780741
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@silviodonato silviodonato mentioned this pull request Jul 3, 2020
Merged
This was referenced Jul 3, 2020
Closed
Closed
Closed
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) #30523,#30520,#30519,#30517,#30515,cms-sw/cmsdist#6024

@cmsbuild cmsbuild mentioned this pull request Jul 3, 2020
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

-1
@silviodonato This pull request cannot be automatically merged, could you please rebase it?

You can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30516/7652/git-merge-result

@silviodonato silviodonato mentioned this pull request Jul 3, 2020
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) #30511

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) #30511,cms-sw/cmsdist#6024

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

-1

Tested at: d1bdc5a

CMSSW: CMSSW_11_1_X_2020-07-03-1200
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4422e6/7679/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
20034.0 step2

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35.log
20434.0 step2 
runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41.log
21234.0 step2 
runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44.log
23234.0 step2 
runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020 •
edited

The tests are being triggered in jenkins.
Tested with other pull request(s) #30511,cms-sw/cmsdist#6024,#30531,#30523

@cmsbuild cmsbuild mentioned this pull request Jul 3, 2020
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2020

-1

Tested at: d1bdc5a

CMSSW: CMSSW_11_1_X_2020-07-03-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43b4bd/7684/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
23234.1001 step1

runTheMatrix-results/23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49/step1_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49.log

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2020

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok comparison-notrun l1-pending orp-approved pending-signatures requires-external tests-rejected upgrade-pending
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@silviodonato @cmsbuild @jbsauvan