Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HGCal build file #3053

Merged
merged 1 commit into from Mar 27, 2014
Merged

Conversation

mark-grimes
Copy link

module.cc is not currently included in GeometryHGCalCommonDataPlugin, so a lot of plugins are compiled but not declared as EDM plugins. In the current Integration Builds tests 122xx, 124xx and 126xx fail with:

----- Begin Fatal Exception 27-Mar-2014 15:20:02 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Processing run: 1
   [1] Running path 'simulation_step'
   [2] Calling beginRun for module OscarProducer/'g4SimHits'
   [3] Using EventSetup component XMLIdealGeometryESSource/'' to make data DDCompactView/'' in record IdealGeometryRecord
Exception Message:
Unable to find plugin 'hgcal:DDHGCalEEAlgo' in category 'DDAlgorithm'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

This pull request should fix them. They still fail in step 2 though.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Fix HGCal build file

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

merge

Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800, 12000, 12800 and 13000 pass all steps.
Tests 13200 and 13400 fail in step 2 with known errors.
Tests 12200, 12400 and 12600 now pass step 1 again, then fail in step 2 with the previous known errors.
This bug was introduced in #3008, I'm slightly concerned that testing didn't pick up the fault.

cmsbuild added a commit that referenced this pull request Mar 27, 2014
@cmsbuild cmsbuild merged commit 0b289ab into cms-sw:CMSSW_6_2_X_SLHC Mar 27, 2014
@andersonjacob
Copy link
Contributor

I wonder if the needed library was found when you tested it because the old
version existed in the base release even though it was lost when the PR was
built. When a new integration build was built though it didn't have the
old library and so this was a new error.

On Thu, Mar 27, 2014 at 5:23 PM, cmsbuild notifications@github.com wrote:

Merged #3053 #3053.

Reply to this email directly or view it on GitHubhttps://github.com//pull/3053
.

@mark-grimes
Copy link
Author

That makes sense. I'm also a little concerned why a problem with a missing HGCal plugin was showing up in the Shashlik tests.

@andersonjacob
Copy link
Contributor

I think that the Shashlik definitions are in the HGCal module.

On Thu, Mar 27, 2014 at 5:45 PM, Mark Grimes notifications@github.comwrote:

That makes sense. I'm also a little concerned why a problem with a missing
HGCal plugin was showing up in the Shashlik tests.

Reply to this email directly or view it on GitHubhttps://github.com//pull/3053#issuecomment-38829124
.

@mark-grimes mark-grimes deleted the fixHGCalBuildFile branch April 7, 2014 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants