Clean BuildFiles in reco plugins

[guitargeek]

PR description:

Another quick partially automatic BuildFile cleaning PR in the style of many before (for example #30139), this time covering all uses in the plugins which are not directly in the root of the BuildFile. My script did not catch these before.

As always, only the dependencies which are not included in any of the plugin sources are removed, so these changes are orthogonal and complementary to the recent PRs which added all packages that are actually included in the libraries.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30535/16762

• This PR adds an extra 84KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoJets/JetPlusTracks/plugins/BuildFile.xml modified in PR(s): Trackjets as seeds of JetPlusTrack at RECO and MINIAOD #30430
  • File RecoTauTag/RecoTau/test/BuildFile.xml modified in PR(s): Add new MVA tau ID for phase II #30341

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

RecoBTag/CTagging
RecoBTag/Combined
RecoBTag/FeatureTools
RecoBTag/PerformanceDB
RecoBTag/PixelCluster
RecoBTag/SecondaryVertex
RecoBTag/SoftLepton
RecoBTau/JetTagComputer
RecoEcal/EgammaClusterProducers
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaTools
RecoEgamma/PhotonIdentification
RecoHI/HiEgammaAlgos
RecoHI/HiTracking
RecoJets/FFTJetProducers
RecoJets/JetAssociationProducers
RecoJets/JetPlusTracks
RecoJets/JetProducers
RecoLocalCalo/CastorReco
RecoLocalCalo/EcalRecAlgos
RecoLocalTracker/SiPixelRecHits
RecoLocalTracker/SubCollectionProducers
RecoLuminosity/LumiProducer
RecoMET/METFilters
RecoMET/METPUSubtraction
RecoMTD/DetLayers
RecoMTD/TimingIDTools
RecoMTD/TrackExtender
RecoMuon/DetLayers
RecoMuon/GlobalTrackingTools
RecoMuon/L3TrackFinder
RecoMuon/MuonIdentification
RecoMuon/MuonIsolation
RecoMuon/TrackerSeedGenerator
RecoMuon/TransientTrackingRecHit
RecoParticleFlow/Configuration
RecoParticleFlow/PFClusterProducer
RecoParticleFlow/PFProducer
RecoParticleFlow/PFSimProducer
RecoParticleFlow/PFTracking
RecoPixelVertexing/PixelTriplets
RecoRomanPot/RecoFP420
RecoTBCalo/EcalTBAnalysisCoreTools
RecoTauTag/RecoTau
RecoTracker/MkFit
RecoVertex/BeamSpotProducer
RecoVertex/ConfigurableVertexReco

@perrotta, @Martin-Grunewald, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @kpedro88, @tlampen, @fwyzard, @pohsun, @santocch can you please review it and eventually sign? Thanks.
@echabert, @rappoccio, @gouskos, @yslai, @felicepantaleo, @jainshilpi, @yduhm, @robervalwalsh, @emilbols, @argiro, @echapon, @alesaggio, @jazzitup, @mandrenguyen, @ahinzmann, @lgray, @abbiendi, @varuns23, @dgulhan, @seemasharmafnal, @smoortga, @HuguesBrun, @JyothsnaKomaragiri, @makortel, @threus, @cericeci, @JanFSchulte, @jhgoh, @amagitte, @apsallid, @yenjie, @clelange, @hqucms, @ferencek, @dkotlins, @pieterdavid, @rociovilar, @Sam-Harper, @hatakeyamak, @afiqaize, @GiacomoSguazzoni, @mmarionncern, @tocheng, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @rovere, @schoef, @mschrode, @ebrondol, @mtosi, @fabiocos, @cbernet, @jdolen, @rchatter, @trocino, @riga, @gbenelli, @Fedespring, @calderona, @mverzett, @sobhatta, @lecriste, @kurtejung, @gpetruc, @mariadalfonso, @yetkinyilmaz, @mmusich, @andrzejnovak, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-03-1200/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7683/console Started: 2020/07/03 23:52

[cmsbuild]

+1
Tested at: bd62d1d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e12fe/7683/summary.html
CMSSW: CMSSW_11_2_X_2020-07-03-1200
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[pohsun]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e12fe/7683/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2784120
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2784069
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 154 log files, 17 edm output root files, 37 DQM output files

[jfernan2]

+1

[santocch]

+1

[kpedro88]

+upgrade

[pohsun]

+1

[slava77]

is this commented out code needed?
Please remove or add comments inline in the code why the commented out block is relevant

[slava77]

... this is new compared to the previously signed by reco version

[slava77]

+1

for #30535 dbff213

• considering 4 signatures out of 6 already collected, Clean BuildFiles in reco plugins #30535 (comment) can be resolved in a follow-up PR

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1