Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Remove Geometry/MTCCTrackerCommonData #30551

Merged
merged 1 commit into from Jul 8, 2020

Conversation

vargasa
Copy link
Contributor

@vargasa vargasa commented Jul 6, 2020

PR description:

Remove Geometry/MTCCTrackerCommonData

Announcement: https://hypernews.cern.ch/HyperNews/CMS/get/tracker-performance/2367.html

Edit:

Package was used long time ago (see below) and no longer used

Quoting @boudoul

MTCC... Magnet Test and Cosmic Challenge - 2006 - It reminds me the good old time :
http://cds.cern.ch/record/1000413/files/CR2006_091.pdf
http://cds.cern.ch/record/987868

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30551/16787

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2020

A new Pull Request was created by @vargasa (Andrés Vargas) for master.

It involves the following packages:

Geometry/MTCCTrackerCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cvuosalo
Copy link
Contributor

cvuosalo commented Jul 7, 2020

@vargasa In the PR description, please give the full name of MTCC and note that it was last used a long time ago, and it is obsolete and no longer used.

@cvuosalo
Copy link
Contributor

cvuosalo commented Jul 7, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

The tests are being triggered in jenkins.

@boudoul
Copy link
Contributor

boudoul commented Jul 7, 2020

MTCC... Magnet Test and Cosmic Challenge - 2006 - It reminds me the good old time :
http://cds.cern.ch/record/1000413/files/CR2006_091.pdf
http://cds.cern.ch/record/987868
....
Thanks for the cleaning ! (and indeed a few words in the description would be good, thank you )

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

+1
Tested at: 50ab353
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86d9b7/7764/summary.html
CMSSW: CMSSW_11_2_X_2020-07-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86d9b7/7764/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787364
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2787307
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Jul 8, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4300551 into cms-sw:master Jul 8, 2020
@vargasa vargasa deleted the Cleanup branch October 9, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants