Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix L1T bugs and add workflows #30568

Merged
merged 6 commits into from Jul 8, 2020
Merged

Fix L1T bugs and add workflows #30568

merged 6 commits into from Jul 8, 2020

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Jul 7, 2020

PR description:

Will backport to 11_1_X.

PR validation:

Ran relevant workflows: 20634.99, 23234.0, 23234.1001, 23234.1002, 23234.21

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30568/16806

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

Configuration/PyReleaseValidation
L1Trigger/Configuration
L1Trigger/L1CaloTrigger
L1Trigger/Phase2L1ParticleFlow

@pgunnell, @benkrikler, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @rekovic can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jul 7, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

The tests are being triggered in jenkins.

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jul 7, 2020

please test workflow 20634.99,23234.0,23234.1001,23234.1002,23234.21

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jul 7, 2020

please abort

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Jenkins tests are aborted.

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jul 7, 2020

please test workflow 20634.99,23234.0,23234.1001,23234.1002,23234.21

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

+1
Tested at: df2df97
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-476849/7755/summary.html
CMSSW: CMSSW_11_2_X_2020-07-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Comparison job queued.

@silviodonato
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-476849/7755/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-476849/20634.99_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41PU_GenSimHLBeamSpotFull14+PREMIX_2026D41PU_PremixHLBeamSpotFull14PU_Premix+DigiFullTriggerPUPRMXCombined_2026D41PU+RecoFullGlobalPUPRMX_2026D41PU+HARVESTFullGlobalPU_2026D41PU
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-476849/23234.1002_TTbar_14TeV+RecoFullGlobal_TestOldDigiProdLike_2026D49+MiniAODFullGlobal_TestOldDigiProdLike_2026D49
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-476849/23234.21_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_ProdLike_2026D49+MiniAODFullGlobal_ProdLike_2026D49

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787364
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2787313
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jul 8, 2020

+upgrade

@srimanob
Copy link
Contributor

srimanob commented Jul 8, 2020

@rekovic @chayanit
Could you please check and sign if OK? Thanks.

@chayanit
Copy link

chayanit commented Jul 8, 2020

+1

@silviodonato
Copy link
Contributor

@kpedro88 could you prepare a backport to 11_1_X? Thanks

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jul 8, 2020

@silviodonato see #30569

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 61d0273 into cms-sw:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProductNotFound (simEcalEBTriggerPrimitiveDigis) in wf 20634.99
5 participants