Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in provenance access by L1TTauOffline (backport to 11_1_X) #30573

Merged

Conversation

swozniewski
Copy link
Contributor

@swozniewski swozniewski commented Jul 7, 2020

PR description:

This PR addresses issue #30324
It fixes a typo to call the right name of the targeted provenance config parameter, which is this one: https://github.com/cms-sw/cmssw/blob/master/RecoTauTag/Configuration/python/HPSPFTaus_cff.py#L287

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #30356

It is a bugfix that is needed to run the concerned analyzer.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

A new Pull Request was created by @swozniewski for CMSSW_11_1_X.

It involves the following packages:

DQMOffline/L1Trigger

@benkrikler, @kmaeshima, @schneiml, @andrius-k, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@swozniewski swozniewski changed the title fix typo in provenance access by L1TTauOffline fix typo in provenance access by L1TTauOffline (backport to 11_1_X) Jul 7, 2020
@jfernan2
Copy link
Contributor

jfernan2 commented Jul 7, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

+1
Tested at: 8bcb1c1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c808ed/7758/summary.html
CMSSW: CMSSW_11_1_X_2020-07-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c808ed/7758/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780741
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@silviodonato
Copy link
Contributor

+1

@silviodonato
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants