Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-gex04 Fix some 2026 geometries by removing interfering duplicate file #30579

Merged
merged 1 commit into from Jul 9, 2020

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jul 7, 2020

PR description:

Fix some 2026 geometries by removing interfering duplicate file

PR validation:

Use runTheMatrix.py with limited option

if this PR is a backport please specify the original PR and why you need to backport that PR:

Is worthwhile to be back ported. This is a bug fix to some Phase2 scenarios

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30579/16813

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Jul 7, 2020

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

+1
Tested at: fcab990
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6f8f1/7762/summary.html
CMSSW: CMSSW_11_2_X_2020-07-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6f8f1/7762/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3365 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787364
  • DQMHistoTests: Total failures: 37788
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2749526
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Jul 8, 2020

What happened in the comparison tests? 3365 differences?

@kpedro88
Copy link
Contributor

kpedro88 commented Jul 8, 2020

The changes are isolated to the D49 workflow. @bsunanda thought the wrong muon constants might have been used in the geometry before this fix.

@bsunanda
Copy link
Contributor Author

bsunanda commented Jul 8, 2020

@kpedro88 @cvuosalo This was exactly my suspicion. I think this needs back porting to 11_1_X.

@kpedro88
Copy link
Contributor

kpedro88 commented Jul 8, 2020

@bsunanda I agree, this indicates a bug. It won't affect the 11_1_X re-reco, but it will impact new samples.

@cvuosalo
Copy link
Contributor

cvuosalo commented Jul 8, 2020

+1

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 5975d06 into cms-sw:master Jul 9, 2020
@kpedro88
Copy link
Contributor

kpedro88 commented Jul 9, 2020

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants