Added new DQM GUI support to all Online DQM clients #30592

andrius-k · 2020-07-08T12:33:16Z

PR description:

Added PB output support to all DQM Online clients.

PR validation:

PR was validated locally as well as in production during the last MWGR.

andrius-k · 2020-07-08T12:33:28Z

please test

cmsbuild · 2020-07-08T12:33:39Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-08T12:41:00Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30592/16844

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMServices/FileIO/plugins/DQMFileSaverPB.cc modified in PR(s): Added QTest support to Protobuf files in DQMFileSaverPB #30357

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30592/16844/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30592/16844/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-07-08T12:51:33Z

The code-checks are being triggered in jenkins.

andrius-k · 2020-07-08T12:51:41Z

please test

cmsbuild · 2020-07-08T13:00:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30592/16846

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQMServices/FileIO/plugins/DQMFileSaverPB.cc modified in PR(s): Added QTest support to Protobuf files in DQMFileSaverPB #30357

cmsbuild · 2020-07-08T13:00:24Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-07-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7777/console Started: 2020/07/08 15:00

cmsbuild · 2020-07-08T13:00:25Z

A new Pull Request was created by @andrius-k (Andrius) for master.

It involves the following packages:

DQM/Integration
DQMServices/FileIO

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic, @threus, @batinkov, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-07-08T14:18:26Z

+1
Tested at: ab283e8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74f619/7777/summary.html
CMSSW: CMSSW_11_2_X_2020-07-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-08T14:18:29Z

Comparison job queued.

cmsbuild · 2020-07-08T16:18:22Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74f619/7777/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2787364
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2787313
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 154 log files, 17 edm output root files, 37 DQM output files

cmsbuild · 2020-09-07T14:44:56Z

The code-checks are being triggered in jenkins.

andrius-k · 2020-09-07T14:45:56Z

please test

This code was successfully running in the last MWGR and is ready to be integrated.

cmsbuild · 2020-09-07T14:50:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30592/18209

This PR adds an extra 136KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/Integration/python/clients/beam_dqm_sourceclient-live_cfg.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQM/Integration/python/clients/beampixel_dqm_sourceclient-live_cfg.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQM/Integration/python/clients/csc_dqm_sourceclient-live_cfg.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQM/Integration/python/clients/fed_dqm_sourceclient-live_cfg.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQM/Integration/python/clients/l1t_dqm_sourceclient-live_cfg.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQM/Integration/python/clients/l1temulator_dqm_sourceclient-live_cfg.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQM/Integration/python/clients/l1tstage1_dqm_sourceclient-live_cfg.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQM/Integration/python/clients/l1tstage1emulator_dqm_sourceclient-live_cfg.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQM/Integration/python/clients/l1tstage2_dqm_sourceclient-live_cfg.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQM/Integration/python/clients/l1tstage2emulator_dqm_sourceclient-live_cfg.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQM/Integration/python/clients/lumi_dqm_sourceclient-live_cfg.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQM/Integration/python/clients/physics_dqm_sourceclient-live_cfg.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQM/Integration/python/clients/pixel_dqm_sourceclient-live_cfg.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQM/Integration/python/clients/pixellumi_dqm_sourceclient-live_cfg.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQM/Integration/python/clients/scal_dqm_sourceclient-live_cfg.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
- File DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983

cmsbuild · 2020-09-07T14:50:26Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-06-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9177/console Started: 2020/09/07 16:51

cmsbuild · 2020-09-07T14:50:28Z

Pull request #30592 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @fioriNTU can you please check and sign again.

cmsbuild · 2020-09-07T16:04:24Z

+1
Tested at: fd636bc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74f619/9177/summary.html
CMSSW: CMSSW_11_2_X_2020-09-06-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-07T16:04:27Z

Comparison job queued.

cmsbuild · 2020-09-07T17:31:45Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74f619/9177/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2609667
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2609639
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
Checked 149 log files, 22 edm output root files, 35 DQM output files

andrius-k · 2020-09-08T07:42:57Z

+1

cmsbuild · 2020-09-08T07:43:24Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-09-08T08:21:07Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Jul 8, 2020

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Jul 8, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 8, 2020

andrius-k force-pushed the dqm-online-live-mode-protobuf-saver branch from d981eeb to ab283e8 Compare July 8, 2020 12:51

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 8, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 8, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 8, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 8, 2020

cmsbuild removed the comparison-pending label Jul 8, 2020

code-format

fd636bc

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 7, 2020

andrius-k marked this pull request as ready for review September 7, 2020 14:45

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 7, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 7, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 7, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 7, 2020

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Sep 8, 2020

cmsbuild added orp-approved and removed orp-pending labels Sep 8, 2020

cmsbuild merged commit 8a44670 into cms-sw:master Sep 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added new DQM GUI support to all Online DQM clients #30592

Added new DQM GUI support to all Online DQM clients #30592

andrius-k commented Jul 8, 2020 •

edited

andrius-k commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

andrius-k commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020 •

edited

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Sep 7, 2020

andrius-k commented Sep 7, 2020

cmsbuild commented Sep 7, 2020

cmsbuild commented Sep 7, 2020 •

edited

cmsbuild commented Sep 7, 2020

cmsbuild commented Sep 7, 2020

cmsbuild commented Sep 7, 2020

cmsbuild commented Sep 7, 2020

andrius-k commented Sep 8, 2020

cmsbuild commented Sep 8, 2020

silviodonato commented Sep 8, 2020

Added new DQM GUI support to all Online DQM clients #30592

Added new DQM GUI support to all Online DQM clients #30592

Conversation

andrius-k commented Jul 8, 2020 • edited

PR description:

PR validation:

andrius-k commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

andrius-k commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020 • edited

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Jul 8, 2020

cmsbuild commented Sep 7, 2020

andrius-k commented Sep 7, 2020

cmsbuild commented Sep 7, 2020

cmsbuild commented Sep 7, 2020 • edited

cmsbuild commented Sep 7, 2020

cmsbuild commented Sep 7, 2020

cmsbuild commented Sep 7, 2020

cmsbuild commented Sep 7, 2020

andrius-k commented Sep 8, 2020

cmsbuild commented Sep 8, 2020

silviodonato commented Sep 8, 2020

andrius-k commented Jul 8, 2020 •

edited

cmsbuild commented Jul 8, 2020 •

edited

cmsbuild commented Sep 7, 2020 •

edited