added esConsumes to modules in RecoLocalMuon/CSCRecHitD

[JamminJones]

PR description:

added esConsumes to 2 modules. This required propagating the consumes collector through many helper classes.

PR validation:

the code compiles

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30598/16852

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalMuon/CSCRecHitD/src/CSCRecoBadChannelsAnalyzer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
  • File RecoLocalMuon/CSCRecHitD/src/CSCRecoConditions.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935

[cmsbuild]

A new Pull Request was created by @JamminJones for master.

It involves the following packages:

CalibMuon/CSCCalibration
RecoLocalMuon/CSCRecHitD
SimMuon/CSCDigitizer

@perrotta, @civanch, @slava77, @christopheralanwest, @mdhildreth, @cmsbuild, @tocheng, @tlampen, @jpata, @pohsun can you please review it and eventually sign? Thanks.
@abbiendi, @jhgoh, @bellan, @tocheng, @dildick, @mmusich, @ptcox, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[christopheralanwest]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-07-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7785/console Started: 2020/07/08 19:09

[Dr15Jones]

This change was made under my supervision.

[cmsbuild]

+1
Tested at: 86792e2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aca605/7785/summary.html
CMSSW: CMSSW_11_2_X_2020-07-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aca605/7785/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2787364
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2787313
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 154 log files, 17 edm output root files, 37 DQM output files

[slava77]

+1

for #30598 86792e2

• code changes are in line with the PR description
• jenkins tests pass and comparisons with the baseline show no differences

[civanch]

+1

[pohsun]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1