Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce boost dependency in L1Trigger/TrackFindingTMTT #30617

Merged
merged 1 commit into from Jul 24, 2020

Conversation

camolezi
Copy link
Contributor

@camolezi camolezi commented Jul 9, 2020

PR description:

Replaced boost::numeric::ublas::matrix for a wrapped std::vector.
Since the boost::matrix here is used basically as an fixed indexed storage, a std::vector replacement should not impact performance significantly.

PR validation:

Passed on basic runTheMatrix test.

I've made a few benchmarks to measure performance differences. And in theory, it should not be significant in this use case.
https://gist.github.com/camolezi/fdffbe34f149552e8601964a7cc87e73

if this PR is a backport please specify the original PR and why you need to backport that PR:

@vgvassilev @davidlange6

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30617/16879

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

A new Pull Request was created by @camolezi (Lucas Camolezi) for master.

It involves the following packages:

L1Trigger/TrackFindingTMTT

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 10, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 8dbef87
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab2c22/7851/summary.html
CMSSW: CMSSW_11_2_X_2020-07-09-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab2c22/7851/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787429
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2787378
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@silviodonato
Copy link
Contributor

@rekovic do you have any comments?

@davidlange6
Copy link
Contributor

shall we move on this with PR?

@silviodonato
Copy link
Contributor

merge
@rekovic

@cmsbuild cmsbuild merged commit a5ea40d into cms-sw:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants