New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce boost dependency in L1Trigger/TrackFindingTMTT #30617
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30617/16879
|
A new Pull Request was created by @camolezi (Lucas Camolezi) for master. It involves the following packages: L1Trigger/TrackFindingTMTT @cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@rekovic do you have any comments? |
shall we move on this with PR? |
merge |
PR description:
Replaced boost::numeric::ublas::matrix for a wrapped std::vector.
Since the boost::matrix here is used basically as an fixed indexed storage, a std::vector replacement should not impact performance significantly.
PR validation:
Passed on basic runTheMatrix test.
I've made a few benchmarks to measure performance differences. And in theory, it should not be significant in this use case.
https://gist.github.com/camolezi/fdffbe34f149552e8601964a7cc87e73
if this PR is a backport please specify the original PR and why you need to backport that PR:
@vgvassilev @davidlange6