Update of the Tracker Online DQM client for Run3 conditions #30630

arossi83 · 2020-07-10T08:20:08Z

PR description:

Update of the Tracker Online DQM client in order to test Run3 configuration (i.e. transition from SCAL to TCDS)

PR validation:

Locally tested with MWGR#1 cosmic run (335507). The flag live need to be changed to "false" on the client under test:

cmsRun "client" dataset=/Cosmics/Commissioning2020-v1/RAW runNumber=335507

if this PR is a backport please specify the original PR and why you need to backport that PR:

this is not a backport, a back port to 11_1_X will be done in order to use this change on MWGR#4

cmsbuild · 2020-07-10T08:20:29Z

The code-checks are being triggered in jenkins.

arossi83 · 2020-07-10T08:21:42Z

@mmusich @sroychow FYI

mmusich · 2020-07-10T08:24:08Z

@cmsbuild, please test

cmsbuild · 2020-07-10T08:25:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30630/16899

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/Integration/python/clients/pixel_dqm_sourceclient-live_cfg.py modified in PR(s): Added new DQM GUI support to all Online DQM clients #30592
- File DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py modified in PR(s): Added new DQM GUI support to all Online DQM clients #30592

cmsbuild · 2020-07-10T08:25:29Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-09-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7847/console Started: 2020/07/10 11:54

cmsbuild · 2020-07-10T08:25:30Z

A new Pull Request was created by @arossi83 (Alessandro Rossi) for master.

It involves the following packages:

DQM/Integration

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-07-10T12:02:35Z

-1

Tested at: ae3ebb0

CMSSW: CMSSW_11_2_X_2020-07-09-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-657bb8/7847/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test TestDQMOnlineClient-pixel_dqm_sourceclient had ERRORS

cmsbuild · 2020-07-10T12:02:37Z

Comparison job queued.

mmusich · 2020-07-10T12:04:59Z

DQM/Integration/python/clients/pixel_dqm_sourceclient-live_cfg.py

@@ -2,8 +2,8 @@
 import FWCore.ParameterSet.Config as cms

 import sys
-from Configuration.Eras.Era_Run2_2018_pp_on_AA_cff import Run2_2018_pp_on_AA
-process = cms.Process("PIXELDQMLIVE", Run2_2018_pp_on_AA)
+from Configuration.Eras.Era_Run3 import Run3


@arossi83 _cff is missing here from Era_Run3_cff

silviodonato · 2020-07-10T12:38:17Z

urgent

cmsbuild · 2020-07-10T12:52:20Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-09-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7860/console Started: 2020/07/10 16:53

cmsbuild · 2020-07-10T12:52:21Z

Pull request #30630 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

cmsbuild · 2020-07-10T14:58:13Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-657bb8/7847/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2787429
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2787378
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 154 log files, 17 edm output root files, 37 DQM output files

cmsbuild · 2020-07-10T16:12:13Z

+1
Tested at: eee0784
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-657bb8/7860/summary.html
CMSSW: CMSSW_11_2_X_2020-07-09-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-10T16:12:16Z

Comparison job queued.

cmsbuild · 2020-07-10T18:04:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-657bb8/7860/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2787429
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2787378
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 154 log files, 17 edm output root files, 37 DQM output files

silviodonato · 2020-07-10T18:14:44Z

merge

Update of the Tracker Online DQM client for Run3 conditions (backport of #30630)

jfernan2 · 2020-07-10T18:46:48Z

+1

cmsbuild · 2020-07-10T18:47:05Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Update of the Tracker Online DQM client for Run3 conditions

ae3ebb0

cmsbuild added this to the CMSSW_11_2_X milestone Jul 10, 2020

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Jul 10, 2020

arossi83 mentioned this pull request Jul 10, 2020

Update of the Tracker Online DQM client for Run3 conditions (backport of #30630) #30631

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 10, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 10, 2020

cmsbuild added tests-rejected and removed tests-started labels Jul 10, 2020

mmusich reviewed Jul 10, 2020

View reviewed changes

cmsbuild added the urgent label Jul 10, 2020

Fix typo on pixel client

eee0784

cmsbuild added code-checks-pending and removed code-checks-approved tests-rejected labels Jul 10, 2020

cmsbuild added the code-checks-approved label Jul 10, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 10, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 10, 2020

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Jul 10, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 10, 2020

cmsbuild added a commit that referenced this pull request Jul 10, 2020

Merge pull request #30631 from arossi83/TkDQM_OnlineClient_update_111X

6c6f82e

Update of the Tracker Online DQM client for Run3 conditions (backport of #30630)

cmsbuild added orp-approved and removed orp-pending labels Jul 10, 2020

cmsbuild merged commit 30aeeb5 into cms-sw:master Jul 10, 2020

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jul 10, 2020

cmsbuild mentioned this pull request Jul 14, 2020

Force the definition of the USEHYBRID preprocessor symbol #30684

Merged

mmusich mentioned this pull request Oct 26, 2020

add tcdsDigis to pixel online DQM client paths and migrate to MagneticField_cff #31938

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update of the Tracker Online DQM client for Run3 conditions #30630

Update of the Tracker Online DQM client for Run3 conditions #30630

arossi83 commented Jul 10, 2020 •

edited

cmsbuild commented Jul 10, 2020

arossi83 commented Jul 10, 2020

mmusich commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020 •

edited

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

mmusich Jul 10, 2020

silviodonato commented Jul 10, 2020

cmsbuild commented Jul 10, 2020 •

edited

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

silviodonato commented Jul 10, 2020

jfernan2 commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

Update of the Tracker Online DQM client for Run3 conditions #30630

Update of the Tracker Online DQM client for Run3 conditions #30630

Conversation

arossi83 commented Jul 10, 2020 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 10, 2020

arossi83 commented Jul 10, 2020

mmusich commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020 • edited

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

mmusich Jul 10, 2020

Choose a reason for hiding this comment

silviodonato commented Jul 10, 2020

cmsbuild commented Jul 10, 2020 • edited

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

silviodonato commented Jul 10, 2020

jfernan2 commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

arossi83 commented Jul 10, 2020 •

edited

cmsbuild commented Jul 10, 2020 •

edited

cmsbuild commented Jul 10, 2020 •

edited