Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fakeEmtfParams name update - Backport to CMSSW_11_1_X #30634

Merged

Conversation

gekobs
Copy link
Contributor

@gekobs gekobs commented Jul 10, 2020

PR description:

Backport of PR#30633 to CMSSW_11_1_X

The backport is needed as PR#29767 updates the fakeEmtfParams_cff module name, breaking the L1 O2O.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gekobs (agzecchinelli) for CMSSW_11_1_X.

It involves the following packages:

L1TriggerConfig/L1TConfigProducers

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@gekobs gekobs changed the title fakeEmtfParams name update fakeEmtfParams name update - Backport to CMSSW_11_1_x Jul 10, 2020
@gekobs gekobs changed the title fakeEmtfParams name update - Backport to CMSSW_11_1_x fakeEmtfParams name update - Backport to CMSSW_11_1_X Jul 10, 2020
@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 10, 2020

The tests are being triggered in jenkins.

@silviodonato
Copy link
Contributor

urgent

@cmsbuild
Copy link
Contributor

+1
Tested at: 4cff8b9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d3e98/7857/summary.html
CMSSW: CMSSW_11_1_X_2020-07-10-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d3e98/7857/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780740
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@silviodonato
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants