Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMTF: Add/Improve text files with some documentation #30643

Merged
merged 4 commits into from Jul 28, 2020

Conversation

jiafulow
Copy link
Contributor

PR description:

This PR improves the text files (.md) currently in L1Trigger/L1TMuonEndCap and adds an additional text file. Specifically:

  • test/globaltags.md is updated so that it is rendered better on GitHub.
  • test/tools/README.md is renamed to test/primconv.md. It is also updated so that it is rendered better on GitHub.
  • test/unpacker.md is added. It contains some basic instructions about the EMTF unpacker.

There are no changes in the codes. Only the text files were added/modified. If anyone wants to include more changes to these text files, please feel free to do so in this PR. The files as rendered on GitHub currently:

The reason to keep these text files in the repo is because they are very easy to lose. Up to now, they have been only circulated in emails. We don't expect to be actively updating these text files, so it won't add more work to the CMSSW maintainers. Though, the unpacker info may be updated in the near future as Jared Sturdy has started working on including GE1/1 in the EMTF unpacker.

PR validation:

N/A

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A


Notifications: @abrinke1 @eyigitba @jsturdy

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30643/16919

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jiafulow (Jia Fu Low) for master.

It involves the following packages:

L1Trigger/L1TMuonEndCap

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

please test

@silviodonato
Copy link
Contributor

@rekovic do you have any comments?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 13, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 00459e9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd5db6/7908/summary.html
CMSSW: CMSSW_11_2_X_2020-07-13-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd5db6/7908/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787429
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2787378
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@silviodonato
Copy link
Contributor

ping @rekovic

@rekovic
Copy link
Contributor

rekovic commented Jul 28, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 77c562a into cms-sw:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants