New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMTF: Add/Improve text files with some documentation #30643
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30643/16919
|
A new Pull Request was created by @jiafulow (Jia Fu Low) for master. It involves the following packages: L1Trigger/L1TMuonEndCap @cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
@rekovic do you have any comments? |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
ping @rekovic |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR improves the text files (
.md
) currently in L1Trigger/L1TMuonEndCap and adds an additional text file. Specifically:test/globaltags.md
is updated so that it is rendered better on GitHub.test/tools/README.md
is renamed totest/primconv.md
. It is also updated so that it is rendered better on GitHub.test/unpacker.md
is added. It contains some basic instructions about the EMTF unpacker.There are no changes in the codes. Only the text files were added/modified. If anyone wants to include more changes to these text files, please feel free to do so in this PR. The files as rendered on GitHub currently:
test/globaltags.md
: globaltags.mdtest/primconv.md
: primconv.mdtest/unpacker.md
: unpacker.mdThe reason to keep these text files in the repo is because they are very easy to lose. Up to now, they have been only circulated in emails. We don't expect to be actively updating these text files, so it won't add more work to the CMSSW maintainers. Though, the unpacker info may be updated in the near future as Jared Sturdy has started working on including GE1/1 in the EMTF unpacker.
PR validation:
N/A
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A
Notifications: @abrinke1 @eyigitba @jsturdy