Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Phase 2 workflows (2020, 11_2_X) #30645

Merged
merged 5 commits into from Jul 14, 2020
Merged

Conversation

kpedro88
Copy link
Contributor

PR description:

Pursuant to #30512:

Remove outdated subdetectors:

  • Tracker: T5, T6, T14, T16
  • HGCal: C4, C6, C8
  • Muon: M2, M3
  • MTD: I5, I7, I9
  • Common: O2, O3

Remove corresponding detector versions & workflows: D35, D41, D43, D44, D45, D46, D48

Replace some detector versions: D47 → D60 (keep C10, M3,F3 → M4,F4), D55 → D61 (keep M5, T19 → T17)

Remove unneeded eras: Phase2C4, Phase2C6, Phase2C8, phase2_trackerV14 (& corresponding dd4hep versions)

Currently, workflow numbers are preserved, to ensure consistency between 11_1_X and 11_2_X. The workflow number reset will be targeted for 12_0_X.

A subsequent PR (on top of this one) will try to consolidate HGCal eras.

Fascinatingly, this PR arrives exactly one year after the last cleanup in #27449 (and also contains a very similar amount of additions and deletions.)

PR validation:

Successfully ran workflows 23234.1001, 23234.103, 28234.0.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30645/16920

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 10, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

Configuration/Eras
Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData
L1Trigger/Configuration

@pgunnell, @benkrikler, @Dr15Jones, @makortel, @chayanit, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @rekovic, @franzoni, @silviodonato, @kpedro88, @civanch, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jul 10, 2020

As D41 is removed, I think this unit test https://github.com/cms-sw/cmssw/blob/master/SLHCUpgradeSimulations/Geometry/test/phase2_digi_reco_pixelntuple.sh#L6 is going to fail. I suppose it could be migrated to use D49 (T15).

@kpedro88
Copy link
Contributor Author

@mmusich thanks for pointing out the unit test. I have fixed it now. (Most files in test/ directories are not actually tested or maintained...)

@cmsbuild
Copy link
Contributor

+1
Tested at: a5e4e40
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc1051/7875/summary.html
CMSSW: CMSSW_11_2_X_2020-07-10-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

+1
Tested at: edac4e6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc1051/7878/summary.html
CMSSW: CMSSW_11_2_X_2020-07-10-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc1051/7875/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-bc1051/28234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D60_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D60+RecoFullGlobal_2026D60+HARVESTFullGlobal_2026D60

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2525996
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2525948
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 142 log files, 17 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc1051/7878/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-bc1051/28234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D60_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D60+RecoFullGlobal_2026D60+HARVESTFullGlobal_2026D60

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2525996
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2525948
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 142 log files, 17 edm output root files, 34 DQM output files

@kpedro88
Copy link
Contributor Author

+upgrade

@chayanit
Copy link

+1

@cvuosalo
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor Author

@rekovic @silviodonato please check and sign

@silviodonato
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants