New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Phase 2 workflows (2020, 11_2_X) #30645
Conversation
The code-checks are being triggered in jenkins. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30645/16920
|
The tests are being triggered in jenkins.
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages: Configuration/Eras @pgunnell, @benkrikler, @Dr15Jones, @makortel, @chayanit, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @rekovic, @franzoni, @silviodonato, @kpedro88, @civanch, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
As D41 is removed, I think this unit test https://github.com/cms-sw/cmssw/blob/master/SLHCUpgradeSimulations/Geometry/test/phase2_digi_reco_pixelntuple.sh#L6 is going to fail. I suppose it could be migrated to use D49 (T15). |
@mmusich thanks for pointing out the unit test. I have fixed it now. (Most files in test/ directories are not actually tested or maintained...) |
+1 |
Comparison job queued. |
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+upgrade |
+1 |
+1 |
@rekovic @silviodonato please check and sign |
merge |
PR description:
Pursuant to #30512:
Remove outdated subdetectors:
Remove corresponding detector versions & workflows: D35, D41, D43, D44, D45, D46, D48
Replace some detector versions: D47 → D60 (keep C10, M3,F3 → M4,F4), D55 → D61 (keep M5, T19 → T17)
Remove unneeded eras: Phase2C4, Phase2C6, Phase2C8, phase2_trackerV14 (& corresponding dd4hep versions)
Currently, workflow numbers are preserved, to ensure consistency between 11_1_X and 11_2_X. The workflow number reset will be targeted for 12_0_X.
A subsequent PR (on top of this one) will try to consolidate HGCal eras.
Fascinatingly, this PR arrives exactly one year after the last cleanup in #27449 (and also contains a very similar amount of additions and deletions.)
PR validation:
Successfully ran workflows 23234.1001, 23234.103, 28234.0.