New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TrackletEventProcessor: properly initialise and check settings #30659
TrackletEventProcessor: properly initialise and check settings #30659
Conversation
Initialise settings_ to nullptr in the constructor. Check that settings_ is not nullptr before accessing it in the destructor.
type bug-fix |
urgent |
The code-checks are being triggered in jenkins. |
@cmsbuild, please test |
@skinnari FYI |
This should fix a crash encountered while testing various Phase 2 workflow, where no runs and lumisections were processed. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30659/16941
|
The tests are being triggered in jenkins.
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: L1Trigger/TrackFindingTracklet @cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
Comparison job queued. |
I guess this makes #30635 moot :) |
Comparison is ready Comparison Summary:
|
Looks like we are all fixing these same bugs ... |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
the memory leak remains here but its not a big deal. Also probably many other horrors lurking... |
Initialise
settings
tonullptr
in the constructor.Check that
settings
is notnullptr
before accessing it in the destructor.Pass
settings
by reference to avoid the possibility of a null pointer.