TTTrack bug fix for POCA

[tomalin]

There was a bug in the variable "thePOCA", which represents the point of closest approach of the helix to the line x=y=0. This will affect anyone who uses the function TTTrack::POCA().

However, people using other TTTrack functions, such as those giving access to the helix parameters, will be unaffected.

I'd suggest back-porting this fix to CMSSW 11.1, if possible, as although I suspect few people use TTTrack::POCA(), the bug will confuse anyone who does.

[cmsbuild]

@tomalin, CMSSW_11_2_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30663/16946

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30663/16946/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30663/16946/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30663/16947

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @tomalin (Ian Tomalin) for master.

It involves the following packages:

DataFormats/L1TrackTrigger

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@rovere, @sviret this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

@tomalin please make also the backport for 11_1_X

[tomalin]

I've added a second PR, #30666 , identical to this one, except that it (hopefully) backports this bug fix to 11_1_X.

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-13-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7918/console Started: 2020/07/13 21:42

[cmsbuild]

+1
Tested at: 2a2f808
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f8690/7918/summary.html
CMSSW: CMSSW_11_2_X_2020-07-13-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f8690/7918/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2787429
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2787373
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 154 log files, 17 edm output root files, 37 DQM output files

[silviodonato]

merge

[kpedro88]

+upgrade