Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up of Tracker conditions for Phase-2 #30695

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 15, 2020

PR description:

Follow-up of #30645 and pursuant of #30512.
As Tracker geometries T6 and T14 have been removed from the release, the corresponding symbolic Global Tags can go as well.
For the remaining geometries (T15,T17,T19,T20) for the sake of clarity new symbolic Global Tags are introduced (even if they employ the same tags as for T15, excepted the Pixel 3D geomery one T19) and are deployed in the corresponding runTheMatrix workflows.
Moreoever there is no need for the SLHCUpgradeSimulations/Geometry/python/fakeConditions_phase2TkT*_cff.py files either because the corresponding geometry has been removed, or because they don't serve any purpose aymore; the dictionary at dict2026Geometry.py is changed accordingly.
Finally the Global Tag used in the test SLHCUpgradeSimulations/Geometry/test/phase2_reco_pixelntuple_cfg.py is bumped up, accordingly to migration to T15 performed in #30645.

PR validation:

Branch passes:

runTheMatrix.py -l limited --ibeos 

and

scramv1 b runtests

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport, and no backport is needed.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30695/16996

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Configuration/AlCa
Configuration/Geometry
Configuration/PyReleaseValidation
Geometry/GEMGeometry
SLHCUpgradeSimulations/Geometry
SimTracker/TrackerMaterialAnalysis

@pgunnell, @civanch, @Dr15Jones, @chayanit, @cvuosalo, @wajidalikhan, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @makortel, @tocheng, @tlampen, @pohsun, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @vargasa, @makortel, @threus, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @jshlee, @apsallid, @ebrondol, @rovere, @dildick, @mmusich, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jul 15, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 15, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: a6f591b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14c9c1/7959/summary.html
CMSSW: CMSSW_11_2_X_2020-07-14-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14c9c1/7959/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-14c9c1/28234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D60_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D60+RecoFullGlobal_2026D60+HARVESTFullGlobal_2026D60

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2612943
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2612894
  • DQMHistoTests: Total skipped: 48
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 146 log files, 17 edm output root files, 35 DQM output files

@kpedro88
Copy link
Contributor

+upgrade
thanks @mmusich, I had forgotten about this part of the cleanup

@chayanit
Copy link

+1

@cvuosalo
Copy link
Contributor

+1

@mmusich
Copy link
Contributor Author

mmusich commented Jul 16, 2020

@civanch,@christopheralanwest, @tocheng, @tlampen, @pohsun

can you please have a look and comment at earliest convenience? We have more PRs that need to build up on this one.

@cmsbuild cmsbuild mentioned this pull request Jul 16, 2020
@civanch
Copy link
Contributor

civanch commented Jul 17, 2020

+1

@pohsun
Copy link

pohsun commented Jul 18, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 65ec0af into cms-sw:master Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants