[Clang tidy] Apply checks for dqm

[cmsbuild]

Apply new clang checks. See #30508 for more info.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30718/17015

• This PR adds an extra 8KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/HGCalValidation/test/HGCGeometryCheck.cc modified in PR(s): remove phase2_hgcalV9 modifier #30702
  • File Validation/HGCalValidation/test/HGCHitValidation.cc modified in PR(s): remove phase2_hgcalV9 modifier #30702

[cmsbuild]

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DQM/SiStripCommon
DQMServices/Components
DQMServices/FwkIO
DQMServices/StreamerIO
Validation/HGCalValidation
Validation/RecoMuon
Validation/TrackerRecHits

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@wmtford, @erikbutz, @abbiendi, @bsunanda, @fioriNTU, @threus, @cericeci, @hdelanno, @jhgoh, @lgray, @apsallid, @HuguesBrun, @trocino, @rociovilar, @vandreev11, @barvic, @rovere, @VinInn, @cseez, @deguio, @hatakeyamak, @idebruyn, @jandrea, @mtosi, @sethzenz, @Fedespring, @calderona, @lecriste, @folguera, @pfs this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-14-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7977/console Started: 2020/07/15 19:49

[cmsbuild]

+1
Tested at: cb7971c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a87c1d/7977/summary.html
CMSSW: CMSSW_11_2_X_2020-07-14-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a87c1d/7977/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a87c1d/28234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D60_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D60+RecoFullGlobal_2026D60+HARVESTFullGlobal_2026D60

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2612943
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2612888
• DQMHistoTests: Total skipped: 48
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 146 log files, 17 edm output root files, 35 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[davidlange6]

@smuzaffar - how is this PR being made? it looks like it reverts changes in the master - eg #30661?

[smuzaffar]

@mrodozov is doing it by hand, he can tell what he did