Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11_2_X L1T FEVTDEBUG EventContent for Phase2 era (keep TTStubs and TTClusters) #30768

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Jul 17, 2020

PR description:

Expand FEVTDEBUG EventContet for Phase2 era to keep TTStubs and TTClusters.

These are needed for proper debugging and validation and L1TrackerTrigger tracks and needed for HLT TDR reprocessing.

Additional comments for HLT TDR reprocessing:

When re-processing HLT TDR we should drop the original TTStubs and TTCluster collections found in the input DIGI file and produced in the original HLT process.

'drop *_TTStubsFromPhase2TrackerDigis_*_HLT',
'drop *_TTClustersFromPhase2TrackerDigis_*_HLT',

Could be done via customization:

--customise_command process.FEVTDEBUGHLToutput.outputCommands.append('drop *_TTStubsFromPhase2TrackerDigis_*_HLT', 'drop *_TTClustersFromPhase2TrackerDigis_*_HLT')

@rekovic
Copy link
Contributor Author

rekovic commented Jul 17, 2020

please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30768/17100

  • This PR adds an extra 16KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 17, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for master.

It involves the following packages:

DataFormats/StdDictionaries
L1Trigger/Configuration

@smuzaffar, @benkrikler, @Dr15Jones, @makortel, @cmsbuild, @rekovic can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @rovere, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor Author

rekovic commented Jul 17, 2020

urgent

@cmsbuild
Copy link
Contributor

+1
Tested at: 19f9637
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2709fc/8038/summary.html
CMSSW: CMSSW_11_2_X_2020-07-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 9e8a6ed into cms-sw:master Jul 17, 2020
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2709fc/8038/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2612943
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2612894
  • DQMHistoTests: Total skipped: 48
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 146 log files, 17 edm output root files, 35 DQM output files

@makortel
Copy link
Contributor

+1

post merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants