[Clang tidy] Apply checks for l1

[cmsbuild]

Apply new clang checks, redone. Apologies for the inconvenience. See #30508 for more info.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30802/17136

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DataFormats/L1Trigger
DataFormats/LTCDigi
EventFilter/L1GlobalTriggerRawToDigi
EventFilter/L1TRawToDigi
L1Trigger/CSCTriggerPrimitives
L1Trigger/GlobalCaloTrigger
L1Trigger/GlobalMuonTrigger
L1Trigger/GlobalTriggerAnalyzer
L1Trigger/L1TCalorimeter
L1Trigger/L1TCommon
L1Trigger/L1TGEM
L1Trigger/L1TGlobal
L1Trigger/L1TMuon
L1Trigger/L1TMuonBarrel
L1Trigger/L1TMuonCPPF
L1Trigger/L1TMuonEndCap
L1Trigger/L1TMuonOverlap
L1Trigger/L1TNtuples
L1Trigger/TrackFindingTMTT
L1Trigger/TrackFindingTracklet
L1TriggerConfig/CSCTFConfigProducers
L1TriggerConfig/DTTPGConfigProducers
L1TriggerConfig/DTTrackFinder
L1TriggerConfig/L1GeometryProducers
L1TriggerConfig/L1GtConfigProducers
L1TriggerConfig/L1TConfigProducers
L1TriggerConfig/RPCTriggerConfig
SimCalorimetry/EcalTrigPrimProducers
SimCalorimetry/HcalTrigPrimAlgos

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko, @battibass, @rchatter, @rovere, @argiro, @valuev, @ptcox, @thomreis, @dildick, @abdoulline this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-17-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8085/console Started: 2020/07/17 21:26

[cmsbuild]

+1
Tested at: 5538652
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6417d3/8085/summary.html
CMSSW: CMSSW_11_2_X_2020-07-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6417d3/8085/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2525996
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2525943
• DQMHistoTests: Total skipped: 47
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 33 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 144 log files, 17 edm output root files, 34 DQM output files

[silviodonato]

ping @rekovic

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1