Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clang tidy] Apply checks for pdmv #30804

Merged
merged 1 commit into from Jul 24, 2020
Merged

Conversation

cmsbuild
Copy link
Contributor

Apply new clang checks, redone. Apologies for the inconvenience. See #30508 for more info.

@cmsbuild
Copy link
Contributor Author

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30804/17137

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DPGAnalysis/Skims

@chayanit, @cmsbuild, @wajidalikhan, @pgunnell can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jul 17, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

+1
Tested at: b3987f0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21fdc1/8083/summary.html
CMSSW: CMSSW_11_2_X_2020-07-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21fdc1/8083/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2525996
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2525943
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

merge
@chayanit, @wajidalikhan, @pgunnell

@cmsbuild cmsbuild merged commit 4829d26 into master Jul 24, 2020
@chayanit
Copy link

+1

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants