[Clang tidy] Apply checks for simulation

[cmsbuild]

Apply new clang checks, redone. Apologies for the inconvenience. See #30508 for more info.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30807/17143

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DataFormats/MuonDetId
Mixing/Base
SimCalorimetry/EcalElectronicsEmulation
SimCalorimetry/EcalSelectiveReadoutAlgos
SimCalorimetry/EcalSelectiveReadoutProducers
SimCalorimetry/EcalSimAlgos
SimCalorimetry/EcalTestBeam
SimCalorimetry/HcalSimProducers
SimCalorimetry/HcalZeroSuppressionProducers
SimG4CMS/Calo
SimG4CMS/CherenkovAnalysis
SimG4CMS/Forward
SimG4CMS/HcalTestBeam
SimG4CMS/ShowerLibraryProducer
SimG4CMS/Tracker
SimG4Core/Application
SimG4Core/CustomPhysics
SimG4Core/Geometry
SimG4Core/GeometryProducer
SimG4Core/PrintGeomInfo
SimGeneral/CaloAnalysis
SimGeneral/DataMixingModule
SimGeneral/MixingModule
SimGeneral/TrackingAnalysis
SimMuon/MCTruth
SimMuon/Neutron
SimPPS/PPSPixelDigiProducer
SimPPS/RPDigiProducer
SimTracker/SiPixelDigitizer
SimTracker/SiStripDigitizer
SimTracker/TrackAssociation
SimTracker/TrackHistory
SimTracker/TrackerHitAssociation
SimTracker/TrackerMaterialAnalysis
SimTransport/PPSProtonTransport

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@echabert, @emilbols, @abbiendi, @robervalwalsh, @argiro, @threus, @mmusich, @cericeci, @JyothsnaKomaragiri, @makortel, @abdoulline, @JanFSchulte, @jhgoh, @dgulhan, @apsallid, @prolay, @HuguesBrun, @slomeo, @ferencek, @trocino, @pieterdavid, @GiacomoSguazzoni, @rovere, @VinInn, @ptcox, @wmtford, @ebrondol, @mtosi, @fabiocos, @rchatter, @battibass, @Fedespring, @calderona, @mverzett, @dkotlins, @vargasa, @smoortga, @mariadalfonso, @andrzejnovak, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-17-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8074/console Started: 2020/07/17 21:20

[cmsbuild]

+1
Tested at: 2bebef8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-133b88/8074/summary.html
CMSSW: CMSSW_11_2_X_2020-07-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-133b88/8074/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2525996
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2525948
• DQMHistoTests: Total skipped: 47
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 144 log files, 17 edm output root files, 34 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1