Simplify SonicCore and redesign SonicTriton #30850

kpedro88 · 2020-07-21T15:22:25Z

PR description:

handle different modes in SonicCore w/ helper SonicDispatcher to reduce templating
SonicClientBase now handles mode and allowedTries parameters directly (allowedTries can still be disabled)
introduce TritonData class to handle more Triton features: multiple named inputs/outputs, different input/output types, and variable dimensions (input and output classes for TritonClient are now maps of TritonData objects)
added test setup for a PyTorch graph network (which requires support for the features listed above) using artifacts generated by @lgray
updated documentation, and added documentation for SonicTriton usage
modified SonicTriton LogInfo time messages slightly to account for above changes

PR validation:

Ran TritonImageProducer and TritonGraphProducer many many times (and SonicCore unit tests).

attn: @violatingcp @drankincms @nhanvtran @jeffkrupa @jmduarte @lgray @jpata

cmsbuild · 2020-07-21T15:22:50Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-21T15:27:55Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30850/17200

This PR adds an extra 84KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30850/17200/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30850/17200/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-07-21T15:31:31Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-21T15:36:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30850/17202

This PR adds an extra 92KB to repository

cmsbuild · 2020-07-21T15:36:28Z

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

HeterogeneousCore/SonicCore
HeterogeneousCore/SonicTriton

@makortel, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2020-07-21T15:37:36Z

please test

cmsbuild · 2020-07-21T15:37:57Z

The tests are being triggered in jenkins.

makortel · 2020-07-21T15:39:21Z

@cmsbuild, please test

fwyzard · 2020-07-21T15:47:21Z

Could you squash the commit history ?
It doesn't seem particularly useful to keep it around after the merge.

cmsbuild · 2020-07-27T20:04:17Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-27T20:09:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30850/17339

This PR adds an extra 40KB to repository
Found files with invalid states:
- HeterogeneousCore/SonicTriton/interface/TritonUtils.h:
  - Added: 2c5aca0
  - Deleted: 49bf75b
- HeterogeneousCore/SonicTriton/src/TritonUtils.cc:
  - Added: 2c5aca0
  - Deleted: 49bf75b

cmsbuild · 2020-07-27T20:10:02Z

Pull request #30850 was updated. @makortel, @cmsbuild, @fwyzard can you please check and sign again.

kpedro88 · 2020-07-27T20:13:59Z

please test

cmsbuild · 2020-07-27T20:14:16Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-27-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8324/console Started: 2020/07/27 22:36

fwyzard · 2020-07-27T20:17:47Z

HeterogeneousCore/SonicCore/src/SonicClientBase.cc

+void SonicClientBase::fillBasePSetDescription(edm::ParameterSetDescription& desc, bool allowRetry) {
+  desc.add<std::string>("mode");
+  if (allowRetry)
+    desc.addUntracked<unsigned>("allowedTries", 0);


Mhm, sorry, this was meant for the ifValue above :-)

fwyzard · 2020-07-27T20:18:17Z

HeterogeneousCore/SonicTriton/src/TritonData.cc

+  int64_t nOutput = sizeShape();
+  dataOut.resize(nOutput * batchSize_, 0);
+  for (unsigned i0 = 0; i0 < batchSize_; ++i0) {
+    const uint8_t* r0;


cmsbuild · 2020-07-27T21:42:28Z

+1
Tested at: 27b8006
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f08a41/8324/summary.html
CMSSW: CMSSW_11_2_X_2020-07-27-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-27T21:42:30Z

Comparison job queued.

fwyzard · 2020-07-27T22:14:28Z

+1

cmsbuild · 2020-07-27T22:15:00Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2020-07-27T23:06:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f08a41/8324/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2525444
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2525390
DQMHistoTests: Total skipped: 47
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 144 log files, 17 edm output root files, 34 DQM output files

silviodonato · 2020-07-28T08:02:26Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Jul 21, 2020

cmsbuild added code-checks-pending comparison-pending heterogeneous-pending orp-pending pending-signatures tests-pending labels Jul 21, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 21, 2020

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 21, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 21, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 21, 2020

Simplify SonicCore and redesign SonicTriton

2c5aca0

kpedro88 force-pushed the SonicTriton2 branch from a2d700d to 2c5aca0 Compare July 21, 2020 15:49

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-started labels Jul 21, 2020

cmsbuild added the tests-pending label Jul 27, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 27, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 27, 2020

fwyzard approved these changes Jul 27, 2020

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Jul 27, 2020

cmsbuild added fully-signed heterogeneous-approved and removed heterogeneous-pending pending-signatures labels Jul 27, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 27, 2020

kpedro88 mentioned this pull request Jul 27, 2020

Simpler syntax for fillDescriptions items with limited choices #30932

Closed

cmsbuild added orp-approved and removed orp-pending labels Jul 28, 2020

cmsbuild merged commit 01319e4 into cms-sw:master Jul 28, 2020

cmsbuild mentioned this pull request Jul 28, 2020

add centrality bin to HI miniAOD #30934

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplify SonicCore and redesign SonicTriton #30850

Simplify SonicCore and redesign SonicTriton #30850

kpedro88 commented Jul 21, 2020 •

edited

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

kpedro88 commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

makortel commented Jul 21, 2020

fwyzard commented Jul 21, 2020

cmsbuild commented Jul 27, 2020

cmsbuild commented Jul 27, 2020

cmsbuild commented Jul 27, 2020

kpedro88 commented Jul 27, 2020

cmsbuild commented Jul 27, 2020 •

edited

fwyzard Jul 27, 2020

fwyzard Jul 27, 2020

cmsbuild commented Jul 27, 2020

cmsbuild commented Jul 27, 2020

fwyzard commented Jul 27, 2020

cmsbuild commented Jul 27, 2020

cmsbuild commented Jul 27, 2020

silviodonato commented Jul 28, 2020

Simplify SonicCore and redesign SonicTriton #30850

Simplify SonicCore and redesign SonicTriton #30850

Conversation

kpedro88 commented Jul 21, 2020 • edited

PR description:

PR validation:

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

kpedro88 commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

makortel commented Jul 21, 2020

fwyzard commented Jul 21, 2020

cmsbuild commented Jul 27, 2020

cmsbuild commented Jul 27, 2020

cmsbuild commented Jul 27, 2020

kpedro88 commented Jul 27, 2020

cmsbuild commented Jul 27, 2020 • edited

fwyzard Jul 27, 2020

Choose a reason for hiding this comment

fwyzard Jul 27, 2020

Choose a reason for hiding this comment

cmsbuild commented Jul 27, 2020

cmsbuild commented Jul 27, 2020

fwyzard commented Jul 27, 2020

cmsbuild commented Jul 27, 2020

cmsbuild commented Jul 27, 2020

silviodonato commented Jul 28, 2020

kpedro88 commented Jul 21, 2020 •

edited

cmsbuild commented Jul 27, 2020 •

edited