Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx256 Try to provide V14 geometry for HGCal #30862

Merged
merged 4 commits into from Jul 27, 2020

Conversation

bsunanda
Copy link
Contributor

PR description:

First phase to go for V14 geometry of HGCal

PR validation:

Tested using runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30862/17219

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30862/17220

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/CaloTopology
Geometry/HGCalCommonData
Geometry/HGCalGeometry
L1Trigger/L1THGCal
SimCalorimetry/HGCalSimProducers
SimG4CMS/Calo
Validation/HGCalValidation

@kmaeshima, @andrius-k, @Dr15Jones, @makortel, @cvuosalo, @schneiml, @benkrikler, @mdhildreth, @ianna, @cmsbuild, @rekovic, @jfernan2, @fioriNTU, @civanch, @kpedro88 can you please review it and eventually sign? Thanks.
@cseez, @vandreev11, @deguio, @sethzenz, @makortel, @rovere, @lgray, @Martin-Grunewald, @apsallid, @pfs, @lecriste, @hatakeyamak, @amarini, @fabiocos, @slomeo, @jbsauvan this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 21, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 2d3192a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d5ecf/8200/summary.html
CMSSW: CMSSW_11_2_X_2020-07-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d5ecf/8226/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2526188
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2526140
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@cvuosalo
Copy link
Contributor

+1

@jfernan2
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

+upgrade

@civanch
Copy link
Contributor

civanch commented Jul 23, 2020

+1

@silviodonato
Copy link
Contributor

merge
@rekovic the L1T part was only L1Trigger/L1THGCal/src/HGCalTriggerTools.cc
https://github.com/cms-sw/cmssw/pull/30862/files#diff-7f3b412da33d951d686ff37aaac23cf8L350

@rekovic
Copy link
Contributor

rekovic commented Jul 28, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants