Add PLT To Event Simulation

[skaplanhex]

I think that I am still having problems with other volumes (perhaps my own) diminishing the number of PSimHits I see in the PLT. Can this be tested? Thanks!

[cmsbuild]

A new Pull Request was created by @skaplanhex (Steven Kaplan) for CMSSW_7_1_X.

Add PLT To Event Simulation

It involves the following packages:

SimG4CMS/Forward
SimGeneral/MixingModule

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

-1
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-03-31-0200/src/SimG4CMS/Forward/src/TotemT1Organization.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-03-31-0200/src/SimG4CMS/Forward/src/TotemT2NumberingSchemeGem.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-03-31-0200/src/SimG4CMS/Forward/src/TotemT2OrganizationGem.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-03-31-0200/src/SimG4CMS/Forward/src/TotemTestGem.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-03-31-0200/src/SimG4CMS/Forward/src/PltSD.cc: In constructor 'PltSD::PltSD(std::string, const DDCompactView&, SensitiveDetectorCatalog&, const edm::ParameterSet&, const SimTrackManager_)':
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-03-31-0200/src/SimG4CMS/Forward/src/PltSD.cc:41:98: error: 'GeV' was not declared in this scope
     energyCut           = m_TrackerSD.getParameter("EnergyThresholdForPersistencyInGeV")_GeV; //default must be 0.5 (?)
                                                                                                  ^
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-03-31-0200/src/SimG4CMS/Forward/src/PltSD.cc:41:98: note: suggested alternative:
In file included from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc481/external/geant4/10.00.p01/include/Geant4/CLHEP/Units/PhysicalConstants.h:42:0,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc481/external/geant4/10.00.p01/include/Geant4/CLHEP/Vector/RotationX.icc:11,


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3087/715/summary.html

[civanch]

@skaplanhex, to fix the problem you need to add header file:

"#include "CLHEP/Units/SystemOfUnits.h"

This is needed after we switch to Geant4 10.0.

Vladimir

[skaplanhex]

@civanch I added the header. Thanks! I tried to compile my area, but I was having compilation issues with an unrelated file. I think it should be ok though.

[cmsbuild]

Pull request #3087 was updated. @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please check and sign again.

[civanch]

Sorry, now I compile myself and you need

#include "CLHEP/Units/GlobalSystemOfUnits.h"

instead of #include "CLHEP/Units/SystemOfUnits.h"

Vladimir

[cmsbuild]

Pull request #3087 was updated. @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please check and sign again.

[cmsbuild]

Pull request #3087 was updated. @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please check and sign again.

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3087/726/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[ktf]

I would recommend removing commented code. In this particular case the change you is also wrong (missing comma). Please remove this completely in a separate pull request.

[skaplanhex]

@ktf OK, I will open the PR in a few minutes. Thank you for the suggestion.

[skaplanhex]

@ktf Done. The pull request can be found here: #3119. Thanks!

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3087/726/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?