Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed use of boost::mpl::vector for dependent Records #30874

Merged
merged 3 commits into from Jul 28, 2020

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Replace the use of boost::mpl::vector with our own edm::mpl::Vector class. The implementation is fairly simple when using C++17 features.

This change was based on a discussion at the Core meeting about the difficulties with boost mpl with respect to generating ROOT modules.

PR validation:

The code compiles and framework unit tests pass.

boost::mpl implementation was found to be very heavy weight and was causing difficulties with attempts to use ROOT's module system. As the use of mpl was fairly simple in the DependentRecord system it was replaced with our own edm::mpl::Vector code.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@Dr15Jones
Copy link
Contributor Author

@davidlange6 FYI

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30874/17245

  • This PR adds an extra 176KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CalibCalorimetry/EcalLaserCorrection
CalibFormats/CaloTPG
CalibFormats/CastorObjects
CalibFormats/HcalObjects
CalibTracker/Records
CondFormats/AlignmentRecord
CondFormats/DataRecord
EventFilter/EcalRawToDigi
FWCore/Framework
FWCore/Integration
FWCore/Utilities
FastSimulation/ParticlePropagator
FastSimulation/SimplifiedGeometryPropagator
FastSimulation/TrackerSetup
Fireworks/Geometry
Geometry/EcalMapping
Geometry/Records
JetMETCorrections/FFTJetObjects
L1Trigger/L1TCommon
L1Trigger/TrackTrigger
L1Trigger/TrackerDTC
L1TriggerConfig/DTTPGConfig
MagneticField/Records
PhysicsTools/PatAlgos
RecoBTag/Records
RecoBTau/JetTagComputer
RecoEcal/EgammaCoreTools
RecoLocalCalo/EcalRecAlgos
RecoLocalCalo/HcalRecAlgos
RecoLocalFastTime/Records
RecoLocalTracker/Records
RecoMTD/Records
RecoMuon/Records
RecoTracker/Record
SimTracker/Records
TrackingTools/RecoGeometry
TrackingTools/Records
TrackingTools/TrackFitters

@ggovi, @lveldere, @sbein, @ianna, @kpedro88, @rekovic, @tlampen, @pohsun, @santocch, @perrotta, @civanch, @makortel, @cmsbuild, @smuzaffar, @Dr15Jones, @cvuosalo, @ssekmen, @mdhildreth, @tocheng, @slava77, @jpata, @benkrikler, @christopheralanwest, @alja can you please review it and eventually sign? Thanks.
@echabert, @rappoccio, @gouskos, @makortel, @felicepantaleo, @jainshilpi, @hatakeyamak, @robervalwalsh, @emilbols, @sviret, @argiro, @echapon, @mschrode, @wddgit, @thomreis, @ahinzmann, @lgray, @abbiendi, @varuns23, @seemasharmafnal, @mmarionncern, @smoortga, @HuguesBrun, @calderona, @pieterdavid, @threus, @peruzzim, @JanFSchulte, @jhgoh, @dgulhan, @apsallid, @prolay, @JyothsnaKomaragiri, @ebrondol, @cericeci, @ferencek, @yduhm, @rociovilar, @mtosi, @Sam-Harper, @GiacomoSguazzoni, @tocheng, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @rovere, @schoef, @alesaggio, @mmusich, @abdoulline, @fabiocos, @clelange, @Martin-Grunewald, @namapane, @jdolen, @rchatter, @trocino, @riga, @battibass, @gbenelli, @Fedespring, @alja, @mverzett, @sobhatta, @lecriste, @afiqaize, @gpetruc, @matt-komm, @mariadalfonso, @andrzejnovak, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 22, 2020

The tests are being triggered in jenkins.

@alja
Copy link
Contributor

alja commented Jul 22, 2020

+1

@cmsbuild cmsbuild mentioned this pull request Jul 27, 2020
@silviodonato
Copy link
Contributor

Do you have any objections?
l1: @benkrikler @rekovic
db: @ggovi

@ggovi
Copy link
Contributor

ggovi commented Jul 28, 2020

+1

@silviodonato
Copy link
Contributor

merge
@rekovic

@cmsbuild cmsbuild merged commit 6db7be5 into cms-sw:master Jul 28, 2020
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Jul 31, 2020
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
fwyzard added a commit to fwyzard/cmssw that referenced this pull request Jul 31, 2020
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Jul 31, 2020
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
@Dr15Jones Dr15Jones deleted the removeMPL branch August 4, 2020 13:18
fwyzard added a commit to fwyzard/cmssw that referenced this pull request Aug 8, 2020
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Aug 8, 2020
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Oct 8, 2020
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Oct 8, 2020
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Oct 19, 2020
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Oct 20, 2020
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Oct 23, 2020
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Nov 6, 2020
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Nov 16, 2020
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Nov 27, 2020
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Dec 25, 2020
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Dec 29, 2020
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Dec 29, 2020
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Dec 29, 2020
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment