Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2 D49 premix workflows in IBs #30875

Merged
merged 1 commit into from Jul 23, 2020
Merged

Conversation

kpedro88
Copy link
Contributor

PR description:

In #30645, the D41 detector and its associated workflows were removed. This left premixing workflows out of the IB testing entirely. D49 premixing workflows are now added to ensure that Phase 2 premixing remains functional and can be easily tested.

PR validation:

Ran the added workflows successfully.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30875/17249

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @cmsbuild, @wajidalikhan, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

please test workflow 23461.97,23434.99

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 22, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 0aa888f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d01015/8228/summary.html
CMSSW: CMSSW_11_2_X_2020-07-22-1200
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d01015/8228/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d01015/23434.99_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49PU_GenSimHLBeamSpotFull14+PREMIX_2026D49PU_PremixHLBeamSpotFull14PU_Premix+DigiFullTriggerPUPRMXCombined_2026D49PU+RecoFullGlobalPUPRMX_2026D49PU+HARVESTFullGlobalPU_2026D49PU
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d01015/23461.97_PREMIXUP26D49_PU25+PREMIX_2026D49PU_PremixHLBeamSpotFullPU_Premix

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2526188
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2526140
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@chayanit
Copy link

+1

@kpedro88
Copy link
Contributor Author

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4c6f509 into cms-sw:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants