Remove use of boost::mpl from Ref.h #30876

Dr15Jones · 2020-07-22T20:07:44Z

PR description:

Using C++17 features allowed implementing the same traits check in a relatively simple manner.

This was done based on a discussion in the Core meeting about the difficulty boost::mpl poses for ROOT modules.

PR validation:

The code compiles. Checks were done on the edm::has_key_compare implementation using compiler explorer.

Using C++17 features allowed implementing the same traits check in a relatively simple manner.

cmsbuild · 2020-07-22T20:08:07Z

The code-checks are being triggered in jenkins.

Dr15Jones · 2020-07-22T20:08:09Z

@davidlange6 FYI

cmsbuild · 2020-07-22T20:13:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30876/17250

This PR adds an extra 20KB to repository

cmsbuild · 2020-07-22T20:13:48Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DataFormats/Common

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @rovere, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2020-07-22T20:23:31Z

please test

cmsbuild · 2020-07-22T20:23:56Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-22-1200/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8229/console Started: 2020/07/22 22:24

Dr15Jones · 2020-07-22T20:27:32Z

See https://godbolt.org/z/f36GPb

cmsbuild · 2020-07-22T22:09:40Z

-1

Tested at: 7622e30

CMSSW: CMSSW_11_2_X_2020-07-22-1200
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Update global tags to use V5 JEC for 2017 data/MC and Run 3 MC and add V7b JR for 2018 data/MC #30478 @christopheralanwest: Update global tags to use V5 JEC for 2017 data/MC and Run 3 MC and add V7b JR for 2018 data/MC
Added links to inspect bin by bin comparison with a raw rootjs viewer #30852 @andrius-k: Added links to inspect bin by bin comparison with a raw rootjs viewer
DD4hep: SimTracker/TrackerMaterialAnalysis XML Location #30865 @vargasa: DD4hep: SimTracker/TrackerMaterialAnalysis XML Location
added esConsumes to modules in RecoTracker/FinalTrackSelectors #30812 @JamminJones: added esConsumes to modules in RecoTracker/FinalTrackSelectors

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c39730/8229/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c39730/8229/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c39730/8229/summary.html

I found follow errors while testing this PR

Failed tests: Build HeaderConsistency

Build:

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-07-22-1200/src/FastSimulation/Event/src/FSimVertex.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-07-22-1200/src/FastSimulation/Event/src/KineParticleFilter.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-07-22-1200/src/DataFormats/HepMCCandidate/interface/GenParticleFwd.h:6,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-07-22-1200/src/FastSimulation/Event/interface/FSimEvent.h:6,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-07-22-1200/src/FastSimulation/Event/src/FSimEvent.cc:2:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-07-22-1200/src/DataFormats/Common/interface/FwdRef.h:129:29: error: 'remove_cv' in namespace 'boost' does not name a template type
     typedef typename boost::remove_cv::type>::type key_type;
                             ^~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-07-22-1200/src/DataFormats/Common/interface/FwdRef.h:129:38: error: expected unqualified-id before '<' token
     typedef typename boost::remove_cv::type>::type key_type;
                                      ^

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Update global tags to use V5 JEC for 2017 data/MC and Run 3 MC and add V7b JR for 2018 data/MC #30478 @christopheralanwest: Update global tags to use V5 JEC for 2017 data/MC and Run 3 MC and add V7b JR for 2018 data/MC
Added links to inspect bin by bin comparison with a raw rootjs viewer #30852 @andrius-k: Added links to inspect bin by bin comparison with a raw rootjs viewer
DD4hep: SimTracker/TrackerMaterialAnalysis XML Location #30865 @vargasa: DD4hep: SimTracker/TrackerMaterialAnalysis XML Location
added esConsumes to modules in RecoTracker/FinalTrackSelectors #30812 @JamminJones: added esConsumes to modules in RecoTracker/FinalTrackSelectors

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c39730/8229/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c39730/8229/git-merge-result

cmsbuild · 2020-07-22T22:09:42Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2020-07-23T20:25:39Z

+1
Tested at: 3c697ab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c39730/8253/summary.html
CMSSW: CMSSW_11_2_X_2020-07-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-23T20:25:42Z

Comparison job queued.

cmsbuild · 2020-07-23T22:02:48Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c39730/8253/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2526188
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2526140
DQMHistoTests: Total skipped: 47
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 144 log files, 17 edm output root files, 34 DQM output files

makortel · 2020-07-23T22:06:27Z

+1

slava77 · 2020-07-23T22:08:33Z

+1

for #30876 3c697ab

the change in reco category is almost trivial, to add a cmath include in RecoLocalCalo/HcalRecAlgos/interface/HBHEPulseShapeFlag.h

smuzaffar · 2020-07-24T06:24:15Z

@smuzaffar is there a way I can run the header consistency check in my own work area?

yes @Dr15Jones , scram b -k check-headers

Dr15Jones · 2020-07-24T14:35:06Z

ping @cms-sw/l1-l2 the change in your area is just the inclusion of a missing header.

silviodonato · 2020-07-27T15:29:02Z

merge

rekovic · 2020-07-28T04:37:16Z

+1

cmsbuild · 2020-07-28T04:37:40Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Remove use of boost::mpl from Ref.h

7622e30

Using C++17 features allowed implementing the same traits check in a relatively simple manner.

cmsbuild added this to the CMSSW_11_2_X milestone Jul 22, 2020

cmsbuild added code-checks-pending comparison-pending core-pending orp-pending pending-signatures tests-pending labels Jul 22, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 22, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 22, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jul 22, 2020

Replace boost::remove_* with std::remove_*

907ec4a

cmsbuild added code-checks-pending and removed code-checks-approved comparison-notrun tests-rejected labels Jul 22, 2020

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Jul 23, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 23, 2020

cmsbuild added core-approved and removed core-pending labels Jul 23, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jul 23, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 27, 2020

cmsbuild merged commit 34a0807 into cms-sw:master Jul 27, 2020

This was referenced Jul 27, 2020

Throw if dereference an unset edm::Handle #30928

Merged

Better GEM handling in CSCDigiToRaw #30925

Merged

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Jul 28, 2020

Dr15Jones deleted the removeMPLfromRef branch July 28, 2020 15:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove use of boost::mpl from Ref.h #30876

Remove use of boost::mpl from Ref.h #30876

Dr15Jones commented Jul 22, 2020

cmsbuild commented Jul 22, 2020

Dr15Jones commented Jul 22, 2020

cmsbuild commented Jul 22, 2020

cmsbuild commented Jul 22, 2020

Dr15Jones commented Jul 22, 2020

cmsbuild commented Jul 22, 2020 •

edited

Dr15Jones commented Jul 22, 2020

cmsbuild commented Jul 22, 2020

cmsbuild commented Jul 22, 2020

cmsbuild commented Jul 23, 2020

cmsbuild commented Jul 23, 2020

cmsbuild commented Jul 23, 2020

makortel commented Jul 23, 2020

slava77 commented Jul 23, 2020

smuzaffar commented Jul 24, 2020

Dr15Jones commented Jul 24, 2020

silviodonato commented Jul 27, 2020

rekovic commented Jul 28, 2020

cmsbuild commented Jul 28, 2020

Remove use of boost::mpl from Ref.h #30876

Remove use of boost::mpl from Ref.h #30876

Conversation

Dr15Jones commented Jul 22, 2020

PR description:

PR validation:

cmsbuild commented Jul 22, 2020

Dr15Jones commented Jul 22, 2020

cmsbuild commented Jul 22, 2020

cmsbuild commented Jul 22, 2020

Dr15Jones commented Jul 22, 2020

cmsbuild commented Jul 22, 2020 • edited

Dr15Jones commented Jul 22, 2020

cmsbuild commented Jul 22, 2020

cmsbuild commented Jul 22, 2020

cmsbuild commented Jul 23, 2020

cmsbuild commented Jul 23, 2020

cmsbuild commented Jul 23, 2020

makortel commented Jul 23, 2020

slava77 commented Jul 23, 2020

smuzaffar commented Jul 24, 2020

Dr15Jones commented Jul 24, 2020

silviodonato commented Jul 27, 2020

rekovic commented Jul 28, 2020

cmsbuild commented Jul 28, 2020

cmsbuild commented Jul 22, 2020 •

edited