106X backport of #30738 (Use dxy sign of GSF track instead of IPTools for pat::Electron) #30892

afiqaize · 2020-07-24T08:56:13Z

PR description:

Backport #30738 in the same way as #29537, with extra switch to activate the fix, and the same era modifier to activate said switch.

PR validation:

The same validation as #30738.

if this PR is a backport please specify the original PR and why you need to backport that P R:

#30738 for use in UL reminiAOD.

cmsbuild · 2020-07-24T08:56:42Z

A new Pull Request was created by @afiqaize (Afiq Anuar) for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Backported from Use dxy sign of GSF track instead of IPTools for pat::Electron #30738

perrotta · 2020-07-24T10:24:14Z

backport of #30738

perrotta · 2020-07-24T10:32:03Z

PhysicsTools/PatAlgos/plugins/PATElectronProducer.cc

@@ -91,6 +91,7 @@ PATElectronProducer::PATElectronProducer(const edm::ParameterSet & iConfig) :
  embedHighLevelSelection_(iConfig.getParameter<bool>("embedHighLevelSelection")),
  beamLineToken_(consumes<reco::BeamSpot>(iConfig.getParameter<edm::InputTag>("beamLineSrc"))),
  pvToken_(mayConsume<std::vector<reco::Vertex> >(iConfig.getParameter<edm::InputTag>("pvSrc"))),  
+  getdBFromTrack_(iConfig.getParameter<bool>("getdBFromTrack")),


This change is not present in the master version!
Please clarify

Yes, because in the master the dxy sign is "just fixed", while in this case the fix has to be activated by this switch.

Compare #28753 and #29537 where the same difference can be seen.

perrotta · 2020-07-24T11:04:36Z

please test

cmsbuild · 2020-07-24T11:05:02Z

The tests are being triggered in jenkins.

CMSSW_10_6_X_2020-07-24-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8268/console Started: 2020/07/24 13:08

cmsbuild · 2020-07-24T12:29:50Z

+1
Tested at: 935e9f5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d227e/8268/summary.html
CMSSW: CMSSW_10_6_X_2020-07-24-1100
SCRAM_ARCH: slc7_amd64_gcc700

cmsbuild · 2020-07-24T12:29:53Z

Comparison job queued.

cmsbuild · 2020-07-24T14:17:18Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d227e/8268/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 3214618
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3214283
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 140 log files, 14 edm output root files, 34 DQM output files

perrotta

Please fix the default value in the fillDescription() method: then this PR is ready to be backported

perrotta · 2020-07-29T07:20:47Z

PhysicsTools/PatAlgos/plugins/PATElectronProducer.cc

@@ -1131,6 +1132,7 @@ void PATElectronProducer::fillDescriptions(edm::ConfigurationDescriptions & desc
                 )->setComment("input with high level selection");
  iDesc.addNode( edm::ParameterDescription<edm::InputTag>("pvSrc", edm::InputTag(), true)
                 )->setComment("input with high level selection");
+  iDesc.add<bool>("getdBFromTrack", true)->setComment("switch IP2D computation to use the GSF track instead of IPTools");


default must be "false" in the backport

cmsbuild · 2020-07-29T09:04:15Z

Pull request #30892 was updated. @perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please check and sign again.

perrotta · 2020-07-29T09:30:11Z

@cmsbuild please test

cmsbuild · 2020-07-29T09:30:37Z

The tests are being triggered in jenkins.

CMSSW_10_6_X_2020-07-28-2300/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8391/console Started: 2020/07/29 11:40

cmsbuild · 2020-07-29T11:00:10Z

+1
Tested at: a30039f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d227e/8391/summary.html
CMSSW: CMSSW_10_6_X_2020-07-28-2300
SCRAM_ARCH: slc7_amd64_gcc700

cmsbuild · 2020-07-29T11:00:13Z

Comparison job queued.

cmsbuild · 2020-07-29T12:55:46Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d227e/8391/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 3214618
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3214283
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 140 log files, 14 edm output root files, 34 DQM output files

perrotta · 2020-07-29T13:02:40Z

+1

The backport is appropriate, taking into account the extra switch added to guarantee the "no change" policy for the production 10_6 release
Jenkins tests pass and show no difference wrt the baseline: the new behavior is only enabled by run2_miniAOD_devel

silviodonato · 2020-08-04T13:56:47Z

merge
@santocch

santocch · 2020-08-07T09:24:00Z

+1

cmsbuild · 2020-08-07T09:24:19Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will be automatically merged.

106X electron dxy sign fix

935e9f5

cmsbuild added this to the CMSSW_10_6_X milestone Jul 24, 2020

cmsbuild added analysis-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jul 24, 2020

cmsbuild added the backport-ok label Jul 24, 2020

perrotta reviewed Jul 24, 2020

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Jul 24, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 24, 2020

slava77 mentioned this pull request Jul 24, 2020

features for UL re-miniAOD in 10_6_X #27889

Closed

41 tasks

cmsbuild added comparison-available and removed comparison-pending labels Jul 24, 2020

perrotta reviewed Jul 29, 2020

View reviewed changes

fillDesc default

a30039f

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Jul 29, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 29, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 29, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 29, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jul 29, 2020

cmsbuild added orp-approved and removed orp-pending labels Aug 4, 2020

cmsbuild merged commit 232bb8f into cms-sw:CMSSW_10_6_X Aug 4, 2020

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels Aug 7, 2020

mariadalfonso mentioned this pull request Mar 23, 2021

EGamma: systematics + UL2016 scale and smearing corrections #33030

Merged

swertz mentioned this pull request Oct 24, 2022

NANO configuration Cleanup #39796

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

106X backport of #30738 (Use dxy sign of GSF track instead of IPTools for pat::Electron) #30892

106X backport of #30738 (Use dxy sign of GSF track instead of IPTools for pat::Electron) #30892

afiqaize commented Jul 24, 2020 •

edited

cmsbuild commented Jul 24, 2020 •

edited

perrotta commented Jul 24, 2020

perrotta Jul 24, 2020

afiqaize Jul 24, 2020

perrotta commented Jul 24, 2020

cmsbuild commented Jul 24, 2020 •

edited

cmsbuild commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

perrotta left a comment

perrotta Jul 29, 2020

cmsbuild commented Jul 29, 2020

perrotta commented Jul 29, 2020

cmsbuild commented Jul 29, 2020 •

edited

cmsbuild commented Jul 29, 2020

cmsbuild commented Jul 29, 2020

cmsbuild commented Jul 29, 2020

perrotta commented Jul 29, 2020

silviodonato commented Aug 4, 2020

santocch commented Aug 7, 2020

cmsbuild commented Aug 7, 2020

106X backport of #30738 (Use dxy sign of GSF track instead of IPTools for pat::Electron) #30892

106X backport of #30738 (Use dxy sign of GSF track instead of IPTools for pat::Electron) #30892

Conversation

afiqaize commented Jul 24, 2020 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that P R:

cmsbuild commented Jul 24, 2020 • edited

perrotta commented Jul 24, 2020

perrotta Jul 24, 2020

Choose a reason for hiding this comment

afiqaize Jul 24, 2020

Choose a reason for hiding this comment

perrotta commented Jul 24, 2020

cmsbuild commented Jul 24, 2020 • edited

cmsbuild commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

perrotta left a comment

Choose a reason for hiding this comment

perrotta Jul 29, 2020

Choose a reason for hiding this comment

cmsbuild commented Jul 29, 2020

perrotta commented Jul 29, 2020

cmsbuild commented Jul 29, 2020 • edited

cmsbuild commented Jul 29, 2020

cmsbuild commented Jul 29, 2020

cmsbuild commented Jul 29, 2020

perrotta commented Jul 29, 2020

silviodonato commented Aug 4, 2020

santocch commented Aug 7, 2020

cmsbuild commented Aug 7, 2020

afiqaize commented Jul 24, 2020 •

edited

cmsbuild commented Jul 24, 2020 •

edited

cmsbuild commented Jul 24, 2020 •

edited

cmsbuild commented Jul 29, 2020 •

edited